aiolabs/bitspire
9
0
Fork 0
Code Issues 52 Pull requests 2 Projects Releases Packages Wiki Activity Actions

fix(cash-in): prevent cancel after bills inserted in insertingBills state

Browse source 
The cancel button was still accessible during insertingBills after a bill
had been stacked (physically irreversible). Now CANCEL in insertingBills
is guarded: no bills → idle, bills present → confirmAbandon warning.
The UI also hides the cancel button once bills are detected.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Patrick Mulligan 2026-02-25 19:35:34 -05:00
commit 13ac74ab86
2 changed files with 23 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
apps/machine/src/views/CashInView.vue
View file

@ -20,8 +20,9 @@ const isElectron = typeof window !== 'undefined' && window.electronAPI !== undef
const showCancelButton = computed(() => { const showCancelButton = computed(() => {
const state = atmStore.nestedState const state = atmStore.nestedState
const hasBills = (atmStore.context?.billsInserted.length ?? 0) > 0 const hasBills = (atmStore.context?.billsInserted.length ?? 0) > 0
// Always show in insertingBills (before bills) and error (without bills) // Show in fetchingRate (no bills yet) and insertingBills only before bills are in
if (state === 'insertingBills' || state === 'fetchingRate') return true if (state === 'fetchingRate') return true
if (state === 'insertingBills' && !hasBills) return true
if (state === 'error' && !hasBills) return true if (state === 'error' && !hasBills) return true
// Hide when bills are in the cash box // Hide when bills are in the cash box
return false return false

22
packages/state-machine/src/machine.ts
View file

@ -426,8 +426,26 @@ export function createATMMachine(
guard: 'hasInsertedBills', guard: 'hasInsertedBills',
target: 'generatingNdebit', target: 'generatingNdebit',
}, },
CANCEL: '#atm.idle', CANCEL: [
TIMEOUT: '#atm.idle', {
// No bills inserted yet: safe to cancel
guard: ({ context }) => context.billsInserted.length === 0,
target: '#atm.idle',
},
{
// Bills already stacked: warn user before abandoning
target: 'confirmAbandon',
},
],
TIMEOUT: [
{
guard: ({ context }) => context.billsInserted.length === 0,
target: '#atm.idle',
},
{
target: 'confirmAbandon',
},
],
}, },
}, },
generatingNdebit: { generatingNdebit: {