aiolabs/bitspire
9
0
Fork 0
Code Issues 52 Pull requests 2 Projects Releases Packages Wiki Activity Actions

fix(hal): re-initialize dispenser after errors

Browse source 
After a dispense error, the F56/Puloon drivers call close() which sets
initialized=false. The next dispense would fail on a closed serial port.
Now checks dispenser.initialized before each dispense and re-inits if
needed, matching the lazy re-init pattern from brain.js (line 4072).

Closes #29

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Patrick Mulligan 2026-03-14 00:14:31 -04:00
commit ab2ea0b811
2 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
apps/machine/electron/hal-service.ts
View file

@ -70,10 +70,11 @@ export async function initializeHal(config: HalConfig): Promise<HalInstance> {
}) })
// Initialize dispenser // Initialize dispenser
await dispenser.init({ const dispenserInitData = {
fiatCode: valConfig.fiatCode, fiatCode: valConfig.fiatCode,
cassettes: dispConfig.cassettes, cassettes: dispConfig.cassettes,
}) }
await dispenser.init(dispenserInitData)
console.log('[HAL] Dispenser initialized') console.log('[HAL] Dispenser initialized')
// Start validator // Start validator
@ -148,6 +149,13 @@ export async function initializeHal(config: HalConfig): Promise<HalInstance> {
dispenseCash: async (amounts): Promise<DispenseResult> => { dispenseCash: async (amounts): Promise<DispenseResult> => {
console.log('[HAL] Dispensing:', amounts) console.log('[HAL] Dispensing:', amounts)
// Re-initialize dispenser if it was closed after a previous error
if (!dispenser.initialized) {
console.log('[HAL] Dispenser not initialized, re-initializing...')
await dispenser.init(dispenserInitData)
console.log('[HAL] Dispenser re-initialized')
}
const notes: number[] = new Array(cassetteDenominations.length).fill(0) const notes: number[] = new Array(cassetteDenominations.length).fill(0)
for (const { denomination, count } of amounts) { for (const { denomination, count } of amounts) {
const idx = cassetteDenominations.indexOf(denomination) const idx = cassetteDenominations.indexOf(denomination)

12
apps/machine/src/services/hal.ts
View file

@ -93,10 +93,11 @@ export async function initializeHalServices(config: HalConfig): Promise<HalServi
}) })
// Initialize dispenser // Initialize dispenser
await dispenser.init({ const dispenserInitData = {
fiatCode: valConfig.fiatCode, fiatCode: valConfig.fiatCode,
cassettes: dispConfig.cassettes, cassettes: dispConfig.cassettes,
}) }
await dispenser.init(dispenserInitData)
console.log('[HAL] Dispenser initialized') console.log('[HAL] Dispenser initialized')
// Start validator // Start validator
@ -121,6 +122,13 @@ export async function initializeHalServices(config: HalConfig): Promise<HalServi
dispenseCash: async (amounts) => { dispenseCash: async (amounts) => {
console.log('[HAL] Dispensing:', amounts) console.log('[HAL] Dispensing:', amounts)
// Re-initialize dispenser if it was closed after a previous error
if (!dispenser.initialized) {
console.log('[HAL] Dispenser not initialized, re-initializing...')
await dispenser.init(dispenserInitData)
console.log('[HAL] Dispenser re-initialized')
}
// Translate { denomination, count }[] to number[] by cassette position // Translate { denomination, count }[] to number[] by cassette position
const notes: number[] = new Array(cassetteDenominations.length).fill(0) const notes: number[] = new Array(cassetteDenominations.length).fill(0)
for (const { denomination, count } of amounts) { for (const { denomination, count } of amounts) {