Wire FX conversion + deposit invoice creation into the booking hold #3

New issue

Closed

opened 2026-07-18 22:19:46 +00:00 by padreug · 1 comment

padreug commented

2026-07-18 22:19:46 +00:00

Owner

The money path is stubbed, so the happy path can't complete end-to-end (even over HTTP).

Work

views_api.py:_to_sats() — replace NotImplementedError with lnbits.utils.exchange_rates.fiat_amount_as_satoshis(amount, currency); pass through unchanged for sat/sats. This is the single place FX happens; the result becomes the canonical amount_sat and must not be recomputed downstream.
api_request_booking (and the Nostr equivalent) — after writing the held booking, create_invoice(wallet_id=room.wallet, amount=deposit_sat, extra={"tag": "chatelet", "booking_id": booking.id}), store payment_hash, set status awaiting_payment.
Deliver the bolt11 to the guest (REST: return it; Nostr: DM — see check-in-DM issue).

Notes

tasks.py:on_invoice_paid already keys off extra["tag"] == "chatelet" and get_booking_by_payment_hash, so once the invoice carries those, settle works.
Respect settings.deposit_percent (already computed into deposit_sat).

Acceptance

On FakeWallet: request a booking → receive a bolt11 → pay it → booking flips to confirmed, dates hard-blocked.

The money path is stubbed, so the happy path can't complete end-to-end (even over HTTP). ### Work - [ ] `views_api.py:_to_sats()` — replace `NotImplementedError` with `lnbits.utils.exchange_rates.fiat_amount_as_satoshis(amount, currency)`; pass through unchanged for `sat`/`sats`. This is the **single** place FX happens; the result becomes the canonical `amount_sat` and must not be recomputed downstream. - [ ] `api_request_booking` (and the Nostr equivalent) — after writing the `held` booking, `create_invoice(wallet_id=room.wallet, amount=deposit_sat, extra={"tag": "chatelet", "booking_id": booking.id})`, store `payment_hash`, set status `awaiting_payment`. - [ ] Deliver the bolt11 to the guest (REST: return it; Nostr: DM — see check-in-DM issue). ### Notes - `tasks.py:on_invoice_paid` already keys off `extra["tag"] == "chatelet"` and `get_booking_by_payment_hash`, so once the invoice carries those, settle works. - Respect `settings.deposit_percent` (already computed into `deposit_sat`). ### Acceptance On FakeWallet: request a booking → receive a bolt11 → pay it → booking flips to `confirmed`, dates hard-blocked.

padreug referenced this issue from a commit

2026-07-18 22:26:18 +00:00

feat: wire FX + deposit invoice into the booking hold (#3)

padreug referenced this issue

2026-07-18 22:26:36 +00:00

feat: wire FX + deposit invoice into the booking hold (#3) #7

padreug referenced this issue from a commit

2026-07-18 23:22:53 +00:00

Merge pull request 'feat: wire FX + deposit invoice into the booking hold (#3)' (#7) from feat/payment-settle into main

padreug commented

2026-07-19 22:20:22 +00:00

Author