From 05593c9c3c8ed5ccecf852d1881a26d00db9b3d6 Mon Sep 17 00:00:00 2001 From: Padreug Date: Sat, 23 May 2026 20:58:20 +0200 Subject: [PATCH 1/7] feat: POST /republish-all admin endpoint Loops over approved events and re-emits each NIP-52 calendar event. Useful as a one-shot migration after the publisher's tag set changes (e.g. the tickets_* tag rollout introduced in this PR) so existing events on a deployed instance pick up the new metadata without each organizer having to edit and save. Gated by check_admin (LNbits instance admin), errors swallowed per-event inside the publisher so one bad row doesn't block the rest. Returns a count summary. Co-Authored-By: Claude Opus 4.7 (1M context) --- views_api.py | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/views_api.py b/views_api.py index 7fd3aa0..b7c6a0d 100644 --- a/views_api.py +++ b/views_api.py @@ -112,6 +112,30 @@ async def api_events_pending( return await get_pending_events() +@events_api_router.post("/republish-all") +async def api_republish_all( + admin: Account = Depends(check_admin), +) -> dict: + """Force-republish every approved event to Nostr relays. Admin only. + + Used by the catalog-bump migration that introduced the AIO ticket + tags: existing events on a deployed instance were published before + the publisher learned the new tag set, so they don't carry + tickets_available / tickets_sold / etc. until something triggers + a republish. This endpoint walks the approved list and re-emits + each calendar event so connected clients see the new metadata + without waiting for a per-event edit. + + Errors are swallowed per-event (logged inside the publisher) so + one bad event doesn't block the rest. Returns a count summary. + """ + events = await get_all_events() + approved = [e for e in events if e.status == "approved" and not e.canceled] + for event in approved: + await publish_or_delete_nostr_event(event) + return {"republished": len(approved), "total": len(events)} + + @events_api_router.get("/settings") async def api_get_settings( admin: Account = Depends(check_admin), -- 2.53.0 From fa2a6e40f0198d9ef26552434c3c63f81f520c82 Mon Sep 17 00:00:00 2001 From: Padreug Date: Sat, 23 May 2026 21:00:30 +0200 Subject: [PATCH 2/7] feat(ui): "Republish all" button on the admin Settings card MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Surfaces the POST /republish-all endpoint added in the previous commit. Lives in the existing admin-gated Settings card on the events extension landing page, so the LNbits operator can trigger the migration without curl + access tokens. Confirm dialog before firing (the endpoint emits one Nostr event per approved row, fine to retry but worth a click of friction). Notification shows the republished/total count on success. Self-closing tags expanded per the LNbits UMD rule (webapp CLAUDE.md > LNbits + Quasar UMD gotchas) — q-separator and q-btn would silently nest wrong otherwise. Co-Authored-By: Claude Opus 4.7 (1M context) --- static/js/index.js | 28 ++++++++++++++++++++++++++++ static/js/index.vue | 22 ++++++++++++++++++++++ 2 files changed, 50 insertions(+) diff --git a/static/js/index.js b/static/js/index.js index 022399c..8ec41a6 100644 --- a/static/js/index.js +++ b/static/js/index.js @@ -9,6 +9,7 @@ window.PageEvents = { pendingEvents: [], allUserEvents: [], isAdmin: false, + republishing: false, settings: { auto_approve: false }, @@ -275,6 +276,33 @@ window.PageEvents = { .catch(LNbits.utils.notifyApiError) }) }, + republishAllEvents() { + LNbits.utils + .confirmDialog( + 'Re-emit every approved event to Nostr relays? This is safe ' + + 'to run multiple times but generates one event per approved row.' + ) + .onOk(() => { + this.republishing = true + LNbits.api + .request('POST', '/events/api/v1/events/republish-all') + .then(response => { + Quasar.Notify.create({ + type: 'positive', + message: + 'Republished ' + + response.data.republished + + ' of ' + + response.data.total + + ' events' + }) + }) + .catch(LNbits.utils.notifyApiError) + .finally(() => { + this.republishing = false + }) + }) + }, foldDateTime(day, time) { // Combine separate date/time inputs into the wire format // expected by the events extension: "YYYY-MM-DD" or diff --git a/static/js/index.vue b/static/js/index.vue index 4117f47..befc230 100644 --- a/static/js/index.vue +++ b/static/js/index.vue @@ -15,6 +15,28 @@ > + +
+
+ Republish to Nostr +
+ Re-emit every approved event so connected clients pick + up the latest tag set. Useful after the extension + publisher changes (e.g. new tickets_* tags) so existing + events don't need a per-event edit. +
+
+
+ +
+
-- 2.53.0 From ced6ca2b2b7591788424ea990470405dc4275fbc Mon Sep 17 00:00:00 2001 From: Padreug Date: Sat, 23 May 2026 21:02:36 +0200 Subject: [PATCH 3/7] feat: organizer-side "Republish mine" button + scoped endpoint MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The admin /republish-all hits every approved event regardless of owner — useful for the catalog migration, but heavy. Organizers who want to re-emit just THEIR own events (e.g. after the AIO publisher gained the tickets_* tags and an organizer's events should pick them up) need a lighter knob. Backend: new POST /republish-mine wallet-scoped via require_admin_key, mirrors api_tickets's `all_wallets=true` shape so the page can re-emit across every wallet the user owns. Filters to approved + non-canceled rows. UI: "Republish mine" button alongside "New Event" so every logged-in user sees it (no isAdmin gate). Loading state + confirm dialog + success count notification. Co-Authored-By: Claude Opus 4.7 (1M context) --- static/js/index.js | 31 +++++++++++++++++++++++++++++++ static/js/index.vue | 20 +++++++++++++++++--- views_api.py | 31 +++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+), 3 deletions(-) diff --git a/static/js/index.js b/static/js/index.js index 8ec41a6..a65f5f8 100644 --- a/static/js/index.js +++ b/static/js/index.js @@ -10,6 +10,7 @@ window.PageEvents = { allUserEvents: [], isAdmin: false, republishing: false, + republishingMine: false, settings: { auto_approve: false }, @@ -303,6 +304,36 @@ window.PageEvents = { }) }) }, + republishMyEvents() { + LNbits.utils + .confirmDialog( + 'Re-emit your approved events to Nostr relays?' + ) + .onOk(() => { + this.republishingMine = true + LNbits.api + .request( + 'POST', + '/events/api/v1/events/republish-mine?all_wallets=true', + this.g.user.wallets[0].adminkey + ) + .then(response => { + Quasar.Notify.create({ + type: 'positive', + message: + 'Republished ' + + response.data.republished + + ' of your ' + + response.data.total + + ' events' + }) + }) + .catch(LNbits.utils.notifyApiError) + .finally(() => { + this.republishingMine = false + }) + }) + }, foldDateTime(day, time) { // Combine separate date/time inputs into the wire format // expected by the events extension: "YYYY-MM-DD" or diff --git a/static/js/index.vue b/static/js/index.vue index befc230..4760c6b 100644 --- a/static/js/index.vue +++ b/static/js/index.vue @@ -42,9 +42,23 @@ - New Event +
+ New Event + +
+
+ Re-emit your approved events to Nostr relays. Useful after + a publisher upgrade or if a relay dropped your events. +
diff --git a/views_api.py b/views_api.py index b7c6a0d..35da0cd 100644 --- a/views_api.py +++ b/views_api.py @@ -136,6 +136,37 @@ async def api_republish_all( return {"republished": len(approved), "total": len(events)} +@events_api_router.post("/republish-mine") +async def api_republish_mine( + all_wallets: bool = Query(False), + key_info: WalletTypeInfo = Depends(require_admin_key), +) -> dict: + """Force-republish the caller's own approved events to Nostr relays. + + Same shape as /republish-all but scoped to events owned by the + authenticated wallet (or all wallets belonging to the wallet's + user when `?all_wallets=true`). Lets the organizer trigger the + same migration the admin uses, without needing instance-admin + rights — useful when the AIO publisher gains a new tag set and + an organizer wants their published events to carry it. + + Only events with `status == "approved"` are republished; pending + and rejected rows aren't on relays in the first place, so a + republish for them would be a no-op (or worse, surface a + proposed-but-not-approved row to subscribers). + """ + wallet_ids: list[str] = [key_info.wallet.id] + if all_wallets: + user = await get_user(key_info.wallet.user) + wallet_ids = user.wallet_ids if user else [] + + events = await get_events(wallet_ids) + approved = [e for e in events if e.status == "approved" and not e.canceled] + for event in approved: + await publish_or_delete_nostr_event(event) + return {"republished": len(approved), "total": len(events)} + + @events_api_router.get("/settings") async def api_get_settings( admin: Account = Depends(check_admin), -- 2.53.0 From 902bafe7f20dfbd2f8535afbcf277517a78c244e Mon Sep 17 00:00:00 2001 From: Padreug Date: Sat, 23 May 2026 21:06:03 +0200 Subject: [PATCH 4/7] feat: POST /tickets/{event_id}/{payment_hash} polling endpoint MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The webapp's useTicketPurchase polls this every 2s after firing Pay with Wallet (or after presenting the QR) to confirm payment before advancing to the ticket-QR success state. Without this endpoint the post-payment poll loop returns 404 indefinitely and the buyer never sees their ticket land — even though set_ticket_paid fired on the invoice listener and the row is correctly marked paid in the DB. Returns {paid: bool, ticket_id?: str}. A missing or cross-event ticket returns paid: false rather than 404 so the poll loop doesn't need to special-case the not-yet-created race. The WebSocket at /tickets/ws/{payment_hash} is more efficient for push notifications — this POST is the fallback for clients that can't open a relay-side socket. Co-Authored-By: Claude Opus 4.7 (1M context) --- views_api.py | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/views_api.py b/views_api.py index 35da0cd..f04f24e 100644 --- a/views_api.py +++ b/views_api.py @@ -623,6 +623,29 @@ async def api_ticket_create( ) +@tickets_api_router.post("/{event_id}/{payment_hash}") +async def api_ticket_payment_status(event_id: str, payment_hash: str) -> dict: + """Poll-style payment confirmation for a pending ticket. + + The webapp's `useTicketPurchase` polls this every 2s after firing + `Pay with Wallet` (or after presenting the QR for an external + wallet) until `paid: true` comes back, then advances to the + ticket-QR success state. The companion WebSocket at + `/tickets/ws/{payment_hash}` is more efficient for pushes — this + endpoint is the fallback for clients that can't open a relay-side + socket. + + Returns `{paid: bool, ticket_id?: str}` so the client can hand off + to the ticket-detail flow without an extra GET. A missing / + cross-event ticket returns `paid: false` rather than 404 so the + poll loop doesn't have to special-case the not-yet-created race. + """ + ticket = await get_ticket(payment_hash) + if not ticket or ticket.event != event_id: + return {"paid": False} + return {"paid": ticket.paid, "ticket_id": ticket.id} + + @tickets_api_router.websocket("/ws/{payment_hash}") async def websocket_endpoint(payment_hash: str, websocket: WebSocket) -> None: await websocket.accept() -- 2.53.0 From 36568d3eee6de3bfcb256891a2baf4359c540c2b Mon Sep 17 00:00:00 2001 From: Padreug Date: Sat, 23 May 2026 21:10:33 +0200 Subject: [PATCH 5/7] fix: propagate CreateTicket.user_id to the persisted ticket row MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit api_ticket_create accepted user_id in the CreateTicket request body (its root_validator even requires user_id XOR name+email), but dropped it on the way to crud.create_ticket — tickets ended up with user_id = NULL and the new GET /tickets/user/{id} endpoint returned an empty list for every webapp buyer. Pull data.user_id alongside name/email and forward it to create_ticket. Backfilling existing rows is left to the operator (deployment-specific data fix); fresh purchases starting from this commit are correctly attributed. Co-Authored-By: Claude Opus 4.7 (1M context) --- views_api.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/views_api.py b/views_api.py index f04f24e..b25d2c4 100644 --- a/views_api.py +++ b/views_api.py @@ -513,6 +513,7 @@ async def api_ticket_create( name = data.name email = data.email + user_id = data.user_id promo_code = data.promo_code.upper() if data.promo_code else None refund_address = data.refund_address nostr_identifier = data.nostr_identifier.strip() if data.nostr_identifier else None @@ -605,6 +606,7 @@ async def api_ticket_create( event=event.id, name=name, email=email, + user_id=user_id, extra={ "applied_promo_code": promo_code, "refund_address": refund_address, -- 2.53.0 From 59068fe09d25141c632897f89aa32923ccac3136 Mon Sep 17 00:00:00 2001 From: Padreug Date: Sat, 23 May 2026 22:35:56 +0200 Subject: [PATCH 6/7] feat: multi-ticket purchases as N rows sharing one payment_hash MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replaces the previous "one row, N seats via extra.quantity" model with proper one-row-per-attendee semantics. Each attendee gets a unique scannable id; the door PUT /register/{ticket_id} marks them registered independently — so a buyer can purchase 3 tickets, hand 2 QRs to friends arriving separately, and each attendee can enter on their own schedule. Schema (migrations_fork.py m002): - ticket.payment_hash: new TEXT column shared across all rows of a multi-ticket purchase. Backfilled `payment_hash = id` for pre-migration rows (id WAS the payment_hash by invariant). Wire: - TicketPaymentRequest grows `ticket_ids: list[str]` so the webapp gets every scannable id back in the create response. - POST /tickets/{event_id}/{payment_hash} polling endpoint now reports `ticket_ids` (every row) + keeps `ticket_id` for back-compat. - api_ticket_create loops quantity times; the first row reuses payment_hash as id (preserves legacy `id == payment_hash` invariant for single-ticket purchases), the rest get urlsafe_short_hash() uuids. Payment flow: - on_invoice_paid fetches all rows by payment_hash and marks each paid via set_ticket_paid, which now increments event.sold by 1 per row (was N per row via extra.quantity — simpler now). The per-event asyncio lock still serializes counter + republish so concurrent multi-ticket purchases for the same event don't reorder the published Nostr state. - Each paid row triggers its own send_ticket_notification_in_ background call — no-op for buyers without nostr_identifier / email, useful when the buyer set those on the row. Co-Authored-By: Claude Opus 4.7 (1M context) --- crud.py | 32 +++++++++++++++- migrations_fork.py | 25 ++++++++++++ models.py | 13 +++++++ tasks.py | 33 ++++++++++++---- views_api.py | 95 +++++++++++++++++++++++++++++----------------- 5 files changed, 155 insertions(+), 43 deletions(-) diff --git a/crud.py b/crud.py index 004fa7f..a72b3b3 100644 --- a/crud.py +++ b/crud.py @@ -41,8 +41,19 @@ async def create_ticket( email: str | None = None, user_id: str | None = None, extra: dict | None = None, + ticket_id: str | None = None, ) -> Ticket: + """Persist one ticket row. + + `payment_hash` is the LNbits invoice hash shared across all rows + of a multi-ticket purchase. `ticket_id` is the row primary key / + scannable id; defaults to `payment_hash` for single-ticket + purchases so the legacy id == payment_hash invariant holds. + Multi-ticket callers pass a unique uuid here so each attendee + gets a distinct scannable QR. + """ now = datetime.now(timezone.utc) + row_id = ticket_id or payment_hash # name/email columns are NOT NULL in the schema, so we store "" when only # user_id is supplied. _parse_ticket_row reverses this on read. @@ -54,7 +65,7 @@ async def create_ticket( db_email = email or "" db_ticket = Ticket( - id=payment_hash, + id=row_id, wallet=wallet, event=event, name=db_name, @@ -65,11 +76,12 @@ async def create_ticket( reg_timestamp=now, time=now, extra=TicketExtra(**extra) if extra else TicketExtra(), + payment_hash=payment_hash, ) await db.insert("events.ticket", db_ticket) return Ticket( - id=payment_hash, + id=row_id, wallet=wallet, event=event, name=name, @@ -80,6 +92,7 @@ async def create_ticket( reg_timestamp=now, time=now, extra=TicketExtra(**extra) if extra else TicketExtra(), + payment_hash=payment_hash, ) @@ -93,6 +106,21 @@ async def update_ticket(ticket: Ticket) -> Ticket: return ticket +async def get_tickets_by_payment_hash(payment_hash: str) -> list[Ticket]: + """All ticket rows sharing the given LNbits invoice payment_hash. + + For a single-ticket purchase returns one row (legacy invariant + `id == payment_hash` still holds). For a multi-ticket purchase + returns the N rows created with shared `payment_hash` but + distinct `id`s — each attendee's scannable QR. + """ + rows = await db.fetchall( + "SELECT * FROM events.ticket WHERE payment_hash = :ph", + {"ph": payment_hash}, + ) + return [Ticket(**_parse_ticket_row(row)) for row in rows] + + async def get_ticket(payment_hash: str) -> Ticket | None: row = await db.fetchone( "SELECT * FROM events.ticket WHERE id = :id", diff --git a/migrations_fork.py b/migrations_fork.py index 365d259..864cbb8 100644 --- a/migrations_fork.py +++ b/migrations_fork.py @@ -103,3 +103,28 @@ async def m001_aio_event_schema(db): await _alter_add_column_safe( db, "ALTER TABLE events.events ADD COLUMN categories TEXT" ) + + +async def m002_ticket_payment_hash(db): + """ + Add `ticket.payment_hash` for multi-ticket purchases. + + Multi-ticket purchases land as N rows sharing one LNbits invoice + (so each attendee gets a distinct scannable QR but the buyer + pays once). `ticket.id` stays the row primary key — for legacy + single-purchase rows it equals payment_hash; for multi-purchase + children it's a uuid generated at create-time. `payment_hash` + is the new join key for invoice lookup. + + Backfill existing rows from id so the + GET-tickets-by-payment-hash path keeps working for pre-migration + data (id was the payment_hash by invariant before this column). + """ + await _alter_add_column_safe( + db, "ALTER TABLE events.ticket ADD COLUMN payment_hash TEXT" + ) + await db.execute( + "UPDATE events.ticket SET payment_hash = id " + "WHERE payment_hash IS NULL OR payment_hash = ''" + ) + diff --git a/models.py b/models.py index d3f43d3..04520a0 100644 --- a/models.py +++ b/models.py @@ -133,6 +133,9 @@ class CreateTicket(BaseModel): nostr_identifier: str | None = None payment_method: str | None = None fiat_provider: str | None = None + # Number of tickets to buy on this single invoice. Bounded so a + # bad client can't run away with the organizer's capacity. + quantity: int = Field(default=1, ge=1, le=10) @root_validator def validate_identifiers(cls, values): @@ -158,6 +161,11 @@ class Ticket(BaseModel): time: datetime reg_timestamp: datetime extra: TicketExtra = Field(default_factory=TicketExtra) + # Shared LNbits invoice payment_hash. Equals `id` for single-ticket + # purchases (legacy + post-migration default). Multi-ticket + # purchases create N rows sharing one payment_hash so each attendee + # gets a distinct scannable id while the buyer pays once. + payment_hash: str | None = None class PublicTicket(BaseModel): @@ -175,3 +183,8 @@ class TicketPaymentRequest(BaseModel): fiat_payment_request: str | None = None fiat_provider: str | None = None is_fiat: bool = False + # Row ids created on this invoice — one for single-ticket + # purchases, N for multi-ticket (each independently scannable at + # the door). Buyers fetch these after payment to render N QRs in + # My Tickets. + ticket_ids: list[str] = Field(default_factory=list) diff --git a/tasks.py b/tasks.py index 1d30dce..1641a75 100644 --- a/tasks.py +++ b/tasks.py @@ -4,7 +4,7 @@ from lnbits.core.models import Payment from lnbits.tasks import register_invoice_listener from loguru import logger -from .crud import get_ticket +from .crud import get_ticket, get_tickets_by_payment_hash from .models import Ticket from .services import send_ticket_notification_in_background, set_ticket_paid @@ -37,13 +37,32 @@ async def on_invoice_paid(payment: Payment) -> None: if not payment.extra or "events" != payment.extra.get("tag"): return - ticket = await get_ticket(payment.payment_hash) - if not ticket: - logger.warning(f"Ticket for payment {payment.payment_hash} not found.") + # Multi-ticket purchases land as N rows sharing this payment_hash; + # each one needs to be marked paid + counted against capacity, and + # each gets its own buyer notification (mostly a no-op when all + # rows are owned by the same buyer, but cheap and consistent). + tickets = await get_tickets_by_payment_hash(payment.payment_hash) + if not tickets: + # Backstop for any legacy row created before the payment_hash + # column was populated by the migration backfill. + legacy = await get_ticket(payment.payment_hash) + if legacy: + tickets = [legacy] + + if not tickets: + logger.warning(f"No tickets for payment {payment.payment_hash}.") return - ticket = await set_ticket_paid(ticket) - send_ticket_notification_in_background(ticket) + paid_tickets: list[Ticket] = [] + for ticket in tickets: + paid_tickets.append(await set_ticket_paid(ticket)) + + for paid_ticket in paid_tickets: + send_ticket_notification_in_background(paid_ticket) + + # Wake up the WebSocket / poll listeners. Forward the first paid + # ticket so the existing single-ticket subscribers still work; the + # webapp re-fetches all ids via the polling endpoint anyway. if payment_listeners.get(payment.payment_hash): for paid_ticket_queue in payment_listeners[payment.payment_hash]: - paid_ticket_queue.put_nowait(ticket) + paid_ticket_queue.put_nowait(paid_tickets[0]) diff --git a/views_api.py b/views_api.py index b25d2c4..c288c20 100644 --- a/views_api.py +++ b/views_api.py @@ -17,6 +17,7 @@ from lnbits.core.crud.wallets import get_wallet from lnbits.core.models import Account, User, WalletTypeInfo from lnbits.core.models.payments import CreateInvoice from lnbits.core.services import create_payment_request +from lnbits.helpers import urlsafe_short_hash from lnbits.decorators import ( check_admin, check_user_exists, @@ -46,6 +47,7 @@ from .crud import ( get_settings, get_ticket, get_tickets, + get_tickets_by_payment_hash, get_tickets_by_user_id, purge_unpaid_tickets, update_event, @@ -508,8 +510,16 @@ async def api_ticket_create( ) if event.canceled: raise HTTPException(status_code=HTTPStatus.GONE, detail="Event is canceled.") - if event.amount_tickets > 0 and event.sold >= event.amount_tickets: - raise HTTPException(status_code=HTTPStatus.GONE, detail="Event is sold out.") + quantity = data.quantity + if event.amount_tickets > 0: + if event.sold >= event.amount_tickets: + raise HTTPException(status_code=HTTPStatus.GONE, detail="Event is sold out.") + remaining = event.amount_tickets - event.sold + if quantity > remaining: + raise HTTPException( + status_code=HTTPStatus.BAD_REQUEST, + detail=f"Only {remaining} ticket(s) remaining for this event.", + ) name = data.name email = data.email @@ -531,7 +541,7 @@ async def api_ticket_create( status_code=HTTPStatus.BAD_REQUEST, detail="Invalid Nostr identifier.", ) from exc - price = event.price_per_ticket + unit_price = event.price_per_ticket extra: dict[str, Any] = {"tag": "events", "name": name, "email": email} if promo_code: @@ -543,7 +553,9 @@ async def api_ticket_create( # get the promocode promo = next(pc for pc in event.extra.promo_codes if pc.code == promo_code) extra["promo_code"] = promo.code - price = event.price_per_ticket * (1 - promo.discount_percent / 100) + unit_price = event.price_per_ticket * (1 - promo.discount_percent / 100) + # Scale by quantity AFTER the promo applies. One invoice, N tickets. + price = unit_price * quantity if payment_method == "fiat" and not event.allow_fiat: raise HTTPException( @@ -600,21 +612,32 @@ async def api_ticket_create( extra=extra, ), ) - await create_ticket( - payment_hash=payment.payment_hash, - wallet=event.wallet, - event=event.id, - name=name, - email=email, - user_id=user_id, - extra={ - "applied_promo_code": promo_code, - "refund_address": refund_address, - "nostr_identifier": nostr_identifier, - "ticket_base_url": str(request.base_url).rstrip("/"), - "sats_paid": payment.sat, - }, - ) + # Multi-ticket purchases land as N rows sharing the LNbits invoice + # payment_hash but with distinct `id`s — one independently + # scannable QR per attendee. The first row reuses payment_hash as + # its id so the legacy single-purchase invariant + # (`id == payment_hash`) still holds for quantity == 1 callers. + ticket_ids: list[str] = [] + sats_per_ticket = payment.sat // quantity if quantity else payment.sat + for index in range(quantity): + row_id = payment.payment_hash if index == 0 else urlsafe_short_hash() + await create_ticket( + payment_hash=payment.payment_hash, + wallet=event.wallet, + event=event.id, + name=name, + email=email, + user_id=user_id, + ticket_id=row_id, + extra={ + "applied_promo_code": promo_code, + "refund_address": refund_address, + "nostr_identifier": nostr_identifier, + "ticket_base_url": str(request.base_url).rstrip("/"), + "sats_paid": sats_per_ticket, + }, + ) + ticket_ids.append(row_id) return TicketPaymentRequest( payment_hash=payment.payment_hash, @@ -622,30 +645,34 @@ async def api_ticket_create( fiat_payment_request=getattr(payment, "extra", {}).get("fiat_payment_request"), fiat_provider=getattr(payment, "fiat_provider", None) or fiat_provider, is_fiat=bool(getattr(payment, "fiat_provider", None) or fiat_provider), + ticket_ids=ticket_ids, ) @tickets_api_router.post("/{event_id}/{payment_hash}") async def api_ticket_payment_status(event_id: str, payment_hash: str) -> dict: - """Poll-style payment confirmation for a pending ticket. + """Poll-style payment confirmation for a pending ticket purchase. - The webapp's `useTicketPurchase` polls this every 2s after firing - `Pay with Wallet` (or after presenting the QR for an external - wallet) until `paid: true` comes back, then advances to the - ticket-QR success state. The companion WebSocket at - `/tickets/ws/{payment_hash}` is more efficient for pushes — this - endpoint is the fallback for clients that can't open a relay-side - socket. + The webapp polls this every 2s after presenting the invoice until + `paid: true` comes back, then advances to the success state. The + companion WebSocket at `/tickets/ws/{payment_hash}` is more + efficient for pushes — this endpoint is the fallback. - Returns `{paid: bool, ticket_id?: str}` so the client can hand off - to the ticket-detail flow without an extra GET. A missing / - cross-event ticket returns `paid: false` rather than 404 so the - poll loop doesn't have to special-case the not-yet-created race. + Returns `{paid, ticket_ids: [...]}` so multi-ticket buyers get + every scannable id back in one response (one for single-ticket + purchases). A missing / cross-event purchase returns + `paid: false` rather than 404 so the poll doesn't have to + special-case the not-yet-created race. """ - ticket = await get_ticket(payment_hash) - if not ticket or ticket.event != event_id: + tickets = await get_tickets_by_payment_hash(payment_hash) + relevant = [t for t in tickets if t.event == event_id] + if not relevant: return {"paid": False} - return {"paid": ticket.paid, "ticket_id": ticket.id} + return { + "paid": all(t.paid for t in relevant), + "ticket_id": relevant[0].id, # back-compat with single-ticket clients + "ticket_ids": [t.id for t in relevant], + } @tickets_api_router.websocket("/ws/{payment_hash}") -- 2.53.0 From 7b761a1aef739b83ec336a1e5fe8a0c850402689 Mon Sep 17 00:00:00 2001 From: Padreug Date: Sat, 23 May 2026 22:45:59 +0200 Subject: [PATCH 7/7] fix: every ticket row gets a fresh short-hash id (no payment_hash reuse) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previous commit reused the LNbits invoice payment_hash as the first row's id, so a 3-ticket purchase ended up with one 64-hex id and two short-hash ids — inconsistent and noisy in My Tickets. Switch every row to urlsafe_short_hash. The shared payment_hash column is the join key for invoice lookups (poll endpoint, ws notifier, on_invoice_paid); rows never need to BE the payment hash, they only need to point at it. Co-Authored-By: Claude Opus 4.7 (1M context) --- views_api.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/views_api.py b/views_api.py index c288c20..e7c118f 100644 --- a/views_api.py +++ b/views_api.py @@ -612,15 +612,15 @@ async def api_ticket_create( extra=extra, ), ) - # Multi-ticket purchases land as N rows sharing the LNbits invoice - # payment_hash but with distinct `id`s — one independently - # scannable QR per attendee. The first row reuses payment_hash as - # its id so the legacy single-purchase invariant - # (`id == payment_hash`) still holds for quantity == 1 callers. + # Each row gets a fresh urlsafe_short_hash id so single- and + # multi-ticket purchases stay shape-consistent — every scannable + # ticket id is a short hash, never the long bolt11 payment_hash. + # The shared `payment_hash` column is the join key for invoice + # lookup (poll endpoint, ws notifier, set_ticket_paid loop). ticket_ids: list[str] = [] sats_per_ticket = payment.sat // quantity if quantity else payment.sat - for index in range(quantity): - row_id = payment.payment_hash if index == 0 else urlsafe_short_hash() + for _ in range(quantity): + row_id = urlsafe_short_hash() await create_ticket( payment_hash=payment.payment_hash, wallet=event.wallet, -- 2.53.0