Padreug
b55d6866d6
Some checks failed
lint.yml / fix: honour per-wave fiat when the organiser set an explicit rail list (pull_request) Failing after 0s
Reported from aio-demo: an event with fiat enabled, Card offered at
checkout, and the purchase refused with "Fiat payments are not enabled
for this ticket wave."
`effective_payment_methods` returned the organiser's explicit
`extra.payment_methods` list before ever consulting the wave:
explicit = list(...)
if explicit:
return explicit # <- the wave never got a look in
So the `wave` argument I added for #61 did nothing in the common case.
The webapp always sets `extra.payment_methods` from its payment-method
checkboxes, which means the explicit path is the normal one, not the
exception — three layers then disagreed:
- the NIP-52 tag advertised `tickets_payment_methods: lightning,fiat`
while omitting `tickets_allow_fiat`, contradicting itself
- the checkout rendered a Card button
- `api_ticket_create`, the only wave-aware check, refused the purchase
Asking about a specific wave means asking what a buyer can actually use
for it, so a rail that wave cannot honour is now dropped. The
event-level question (no wave) still reports every rail the organiser
enabled — that is what `/republish-all` and the admin views want.
Fiat-only rails on a non-fiat wave now yield an empty list, which is
honest: nothing is purchasable from that wave.
5 tests, including both publisher shapes with an explicit list — the
case that actually bit, and which the #61 tests missed because their
fixtures left `payment_methods` empty. 133 pass.
Does not fix the data on events already created through the webapp:
their waves were saved with `allow_fiat` unset, so those waves genuinely
cannot take fiat until toggled. That is aiolabs/webapp's side.
|
||
|---|---|---|
| .. | ||
| __init__.py | ||
| test_capacity_guard.py | ||
| test_crud_ticket_email.py | ||
| test_frontend_root.py | ||
| test_init.py | ||
| test_nostr_publish_pending.py | ||
| test_nostr_timestamp.py | ||
| test_promo.py | ||
| test_promo_api.py | ||
| test_publish_active_wave.py | ||
| test_publish_availability.py | ||
| test_publish_confirmation.py | ||
| test_ticket_email.py | ||
| test_ticket_models.py | ||
| test_ticket_qr.py | ||
| test_wave_capacity_required.py | ||
| test_wave_preservation_on_edit.py | ||
| test_wave_transition_sweep.py | ||