fix(fava): serialize source mutations, share HTTP client, validate BQL input
Fava-client hardening cluster (CODE-REVIEW-2026-06 #7, #14, #15, #19 + libra-#23, libra-#53): - New FavaClient.transform_source_line does the whole read-checksum-modify-write under the global write lock and maps Fava 409/412 to ChecksumConflictError. The approve and reject endpoints used to do this dance with raw httpx and no lock — two concurrent mutations raced each other and every other ledger writer (libra-#23). They now route through the new method and translate conflicts to HTTP 409. - update_entry_source / delete_entry raise ChecksumConflictError on 409/412 instead of leaking raw HTTPStatusError. - One shared httpx.AsyncClient per FavaClient (12 per-call instantiations removed — no more TCP handshake per request); closed via libra_stop. Health probes keep their 2s timeout per-request. - Account names/patterns are validated against ^[A-Za-z0-9:_-]+$ before interpolation into BQL string literals. - The posting amount regexes are consolidated into module-level compiled patterns, all decimal-tolerant — the old integer-only SATS pattern silently dropped decimal-SATS postings (Fava's @@->@ normalisation emits them) from balances. - add-account no longer verifies its own write with a second serialized get_all_accounts round-trip (libra-#53): sync_single_account_from_beancount grows an assume_exists path. New test: concurrent approve+reject must both land (was lost-update/412 before the lock). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
c0c8acbe30
commit
4d63e08a69
5 changed files with 305 additions and 123 deletions
11
__init__.py
11
__init__.py
|
|
@ -30,6 +30,17 @@ def libra_stop():
|
|||
except Exception as ex:
|
||||
logger.warning(ex)
|
||||
|
||||
# Close the Fava client's shared HTTP connection pool. libra_stop is
|
||||
# synchronous, so schedule the close; if the loop is already gone the
|
||||
# sockets die with the process anyway.
|
||||
from .fava_client import _fava_client
|
||||
|
||||
if _fava_client is not None:
|
||||
try:
|
||||
asyncio.get_event_loop().create_task(_fava_client.aclose())
|
||||
except Exception as ex:
|
||||
logger.warning(f"Could not close Fava HTTP client: {ex}")
|
||||
|
||||
|
||||
def libra_start():
|
||||
"""Initialize Libra extension background tasks"""
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue