Admin endpoint: POST /api/v1/admin/accounts for chart-of-accounts entries #29

New issue

Closed

opened 2026-06-06 13:15:08 +00:00 by padreug · 0 comments

padreug commented

2026-06-06 13:15:08 +00:00

Owner

Backend API stub for admin-driven chart-of-accounts editing from the LNbits UI. v1 scope: add only. Edit/rename/mark-closed are tracked separately.

Depends on fava_client.add_account gaining a target_file parameter (companion issue).

Work

Add to views_api.py near line 3601 (next to existing admin account-sync endpoint):

@libra_api_router.post("/api/v1/admin/accounts")
async def api_admin_add_chart_account(
    payload: dict,
    auth: AuthContext = Depends(require_super_user),
) -> dict:
    """Add a chart-of-accounts entry (super-user only)."""
    from .fava_client import get_fava_client
    name = payload["name"]
    currencies = payload.get("currencies") or ["EUR", "SATS", "USD"]
    fava = get_fava_client()
    await fava.add_account(
        account_name=name,
        currencies=currencies,
        target_file="accounts/chart.beancount",
        metadata={"added_by": auth.user_id[:8], "source": "admin-ui"},
    )
    from .account_sync import sync_single_account_from_beancount
    await sync_single_account_from_beancount(name)
    return {"success": True, "account_name": name}

Confirm require_super_user is the right guard (per ~/dev/shared/extensions/libra/CLAUDE.md: check_admin is wallet-key, check_super_user is instance super-user — this is the latter)
Validate name conforms to Beancount account naming (Assets:|Liabilities:|Equity:|Income:|Expenses: prefix, valid component chars)
Reject duplicate adds (the underlying fava write is idempotent but worth surfacing)

Acceptance

403 for non-super-user
New open directive appears in /var/lib/fava/accounts/chart.beancount
Account becomes queryable in fava UI and via libra's get_all_accounts
Account is registered in libra DB via account_sync.sync_single_account_from_beancount

Plan reference: ~/.claude/plans/elegant-bubbling-frog.md section B.3.

Follow-up issue (not this one): admin UI frontend.

Backend API stub for admin-driven chart-of-accounts editing from the LNbits UI. v1 scope: **add only**. Edit/rename/mark-closed are tracked separately. Depends on `fava_client.add_account` gaining a `target_file` parameter (companion issue). ## Work - [ ] Add to `views_api.py` near line 3601 (next to existing admin account-sync endpoint): ```python @libra_api_router.post("/api/v1/admin/accounts") async def api_admin_add_chart_account( payload: dict, auth: AuthContext = Depends(require_super_user), ) -> dict: """Add a chart-of-accounts entry (super-user only).""" from .fava_client import get_fava_client name = payload["name"] currencies = payload.get("currencies") or ["EUR", "SATS", "USD"] fava = get_fava_client() await fava.add_account( account_name=name, currencies=currencies, target_file="accounts/chart.beancount", metadata={"added_by": auth.user_id[:8], "source": "admin-ui"}, ) from .account_sync import sync_single_account_from_beancount await sync_single_account_from_beancount(name) return {"success": True, "account_name": name} ``` - [ ] Confirm `require_super_user` is the right guard (per `~/dev/shared/extensions/libra/CLAUDE.md`: `check_admin` is wallet-key, `check_super_user` is instance super-user — this is the latter) - [ ] Validate name conforms to Beancount account naming (`Assets:|Liabilities:|Equity:|Income:|Expenses:` prefix, valid component chars) - [ ] Reject duplicate adds (the underlying fava write is idempotent but worth surfacing) ## Acceptance - 403 for non-super-user - New `open` directive appears in `/var/lib/fava/accounts/chart.beancount` - Account becomes queryable in fava UI and via libra's `get_all_accounts` - Account is registered in libra DB via `account_sync.sync_single_account_from_beancount` Plan reference: `~/.claude/plans/elegant-bubbling-frog.md` section B.3. Follow-up issue (not this one): admin UI frontend.

padreug referenced this issue from a commit

2026-06-06 13:30:49 +00:00

Add POST /api/v1/admin/accounts for chart-of-accounts entries

padreug referenced this issue from a pull request that will close it,

2026-06-06 17:59:29 +00:00

Route account writes for the split Fava ledger layout #32

padreug closed this issue

2026-06-06 18:03:26 +00:00

padreug referenced this issue

2026-06-06 18:06:29 +00:00

Settlement flow doesn't net related expense + income entries (links + postings incomplete) #33