Padreug
ec6cac51f0
One pass over the LOW-tier review items plus two folded issues: - Delete validate_journal_entry (dead since the Fava migration; it validated the pre-string-amount model) with its exports, unused crud imports, and tests. Beancount validates entries now. - Migration m006: UNIQUE index on user_roles(user_id, role_id) after deduping; assign_user_role inserts with ON CONFLICT DO NOTHING and returns the existing assignment — closes the auto-assign check-then-act race on concurrent logins. - Extract _get_username_from_user_id (110 lines in views_api, fresh LNbits Database per call inside per-row hot paths) into user_lookup.py with one shared core-DB handle, a 60s TTL cache and a batch get_usernames API (review #18). - Receivable-entry responses report CLEARED, matching the flag the formatter actually writes; PENDING misled the UI (libra-#35). - Replace the remaining print() calls in tasks.py with logger. - get_all_accounts derives valid roots from account_utils.ACCOUNT_TYPE_ROOTS instead of a hardcoded tuple, and the no-op per-test rate-limit reset is gone (libra-#54). - Delete migrations_old.py.bak, MIGRATION_SQUASH_SUMMARY.md, docs/PHASE*_COMPLETE.md and the rendered .html; .gitignore data/ (it holds the runtime .lnbits_auth_key secret). - Track docs/CODE-REVIEW-2026-06.md with finding statuses updated for the PR #55-#59 + chore/hygiene series. - CLAUDE.md notes LNbits pins Pydantic v1: keep .dict(), don't "modernize" to .model_dump(). Note: format_payment_entry's is_payable docstring (flagged in review follow-up) turned out to be consistent with the body — no change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
24 lines
684 B
Python
24 lines
684 B
Python
"""
|
|
Libra Core Module - Pure accounting logic separated from database operations.
|
|
|
|
This module contains the core business logic for double-entry accounting,
|
|
following Beancount patterns for clean architecture:
|
|
|
|
- validation.py: Comprehensive validation rules
|
|
|
|
Benefits:
|
|
- Testable without database
|
|
- Reusable across different storage backends
|
|
- Clear separation of concerns
|
|
- Easier to audit and verify
|
|
|
|
Note: Balance calculation and inventory tracking have been migrated to Fava/Beancount.
|
|
All accounting calculations are now performed via Fava's query API.
|
|
"""
|
|
|
|
from .validation import ValidationError, validate_balance
|
|
|
|
__all__ = [
|
|
"ValidationError",
|
|
"validate_balance",
|
|
]
|