Simplify error handling

This commit is contained in:
Daniel Lugo 2021-12-27 15:28:38 -04:00
parent 316f631e49
commit 12cacca5c3

View file

@ -758,10 +758,7 @@ module.exports = async (
} }
if (isUnlocked) { if (isUnlocked) {
return res.status(400).json({ throw new Error('Wallet is already unlocked')
field: 'wallet',
errorMessage: 'Wallet is already unlocked'
})
} }
const [genSeedErr, genSeedResponse] = await new Promise(res => { const [genSeedErr, genSeedResponse] = await new Promise(res => {
@ -776,18 +773,10 @@ module.exports = async (
const healthResponse = await checkHealth() const healthResponse = await checkHealth()
if (healthResponse.LNDStatus.success) { if (healthResponse.LNDStatus.success) {
const message = genSeedErr.details const message = genSeedErr.details
return res.status(400).json({ throw new Error(message)
field: 'GenSeed',
errorMessage: message,
success: false
})
} }
return res.status(500).json({ throw new Error('LND is down')
field: 'health',
errorMessage: 'LND is down',
success: false
})
} }
logger.debug('GenSeed:', genSeedResponse) logger.debug('GenSeed:', genSeedResponse)
@ -825,17 +814,9 @@ module.exports = async (
if (healthResponse.LNDStatus.success) { if (healthResponse.LNDStatus.success) {
const errorMessage = initWalletErr.details const errorMessage = initWalletErr.details
return res.status(400).json({ throw new Error(errorMessage)
field: 'initWallet',
errorMessage,
success: false
})
} }
return res.status(500).json({ throw new Error('LND is down')
field: 'health',
errorMessage: 'LND is down',
success: false
})
} }
logger.info('initWallet:', initWalletResponse) logger.info('initWallet:', initWalletResponse)
@ -872,7 +853,7 @@ module.exports = async (
}) })
} catch (err) { } catch (err) {
logger.error(err) logger.error(err)
res.status(400).json({ res.status(500).json({
field: 'unknown', field: 'unknown',
errorMessage: sanitizeLNDError(err.message) errorMessage: sanitizeLNDError(err.message)
}) })