Merge pull request #263 from shocknet/sendpayment-payment-status

be mindful of sendPayment status
This commit is contained in:
Daniel Lugo 2020-12-02 11:12:40 -04:00 committed by GitHub
commit 454bca89f7

View file

@ -229,16 +229,8 @@ const sendPaymentV2 = sendPaymentRequest => {
) )
} }
/**
* @type {SendPaymentV2Request}
*/
const paymentRequest = {
...sendPaymentRequest,
no_inflight_updates: true
}
return new Promise((res, rej) => { return new Promise((res, rej) => {
const stream = router.sendPaymentV2(paymentRequest) const stream = router.sendPaymentV2(sendPaymentRequest)
stream.on( stream.on(
'data', 'data',
@ -247,8 +239,12 @@ const sendPaymentV2 = sendPaymentRequest => {
*/ streamingPaymentV2 => { */ streamingPaymentV2 => {
if (streamingPaymentV2.failure_reason !== 'FAILURE_REASON_NONE') { if (streamingPaymentV2.failure_reason !== 'FAILURE_REASON_NONE') {
rej(new Error(streamingPaymentV2.failure_reason)) rej(new Error(streamingPaymentV2.failure_reason))
} else { } else if (streamingPaymentV2.status === 'FAILED') {
rej(new Error(streamingPaymentV2.failure_reason))
} else if (streamingPaymentV2.status === 'SUCCEEDED') {
res(streamingPaymentV2) res(streamingPaymentV2)
} else {
logger.info(`sendPaymentV2 -> status: ${streamingPaymentV2.status}`)
} }
} }
) )
@ -256,6 +252,9 @@ const sendPaymentV2 = sendPaymentRequest => {
// @ts-expect-error // @ts-expect-error
stream.on('status', status => { stream.on('status', status => {
logger.info('SendPaymentV2 Status:', status) logger.info('SendPaymentV2 Status:', status)
if (status === 'FAILED') {
rej(new Error('Status == FAILED'))
}
}) })
stream.on( stream.on(