From 8d35874c567be2135ae74fc99baf7e75f545fee9 Mon Sep 17 00:00:00 2001
From: Daniel Lugo <danlugo92@gmail.com>
Date: Tue, 25 Feb 2020 15:49:36 -0400
Subject: [PATCH] better error messages

---
 services/gunDB/Mediator/index.js | 46 +++++++++++++++++++++++++++-----
 1 file changed, 39 insertions(+), 7 deletions(-)

diff --git a/services/gunDB/Mediator/index.js b/services/gunDB/Mediator/index.js
index 6f4cc566..94c34da1 100644
--- a/services/gunDB/Mediator/index.js
+++ b/services/gunDB/Mediator/index.js
@@ -90,17 +90,52 @@ mySEA.decrypt = (encMsg, secret) => {
 
 mySEA.secret = (recipientOrSenderEpub, recipientOrSenderSEA) => {
   if (typeof recipientOrSenderEpub !== 'string') {
-    throw new TypeError('epub has to be an string')
+    throw new TypeError(
+      'epub has to be an string, args:' +
+        `${JSON.stringify(recipientOrSenderEpub)} -- ${JSON.stringify(
+          recipientOrSenderSEA
+        )}`
+    )
+  }
+  if (recipientOrSenderEpub.length === 0) {
+    throw new TypeError(
+      'epub has to be populated string, args: ' +
+        `${JSON.stringify(recipientOrSenderEpub)} -- ${JSON.stringify(
+          recipientOrSenderSEA
+        )}`
+    )
   }
   if (typeof recipientOrSenderSEA !== 'object') {
-    throw new TypeError('sea has to be an object')
+    throw new TypeError(
+      'sea has to be an object, args: ' +
+        `${JSON.stringify(recipientOrSenderEpub)} -- ${JSON.stringify(
+          recipientOrSenderSEA
+        )}`
+    )
   }
   if (recipientOrSenderEpub === recipientOrSenderSEA.pub) {
-    throw new Error('Do not use pub for mysecret')
+    throw new Error(
+      'Do not use pub for mysecret, args: ' +
+        `${JSON.stringify(recipientOrSenderEpub)} -- ${JSON.stringify(
+          recipientOrSenderSEA
+        )}`
+    )
   }
   return SEAx.secret(recipientOrSenderEpub, recipientOrSenderSEA).then(sec => {
     if (typeof sec !== 'string') {
-      throw new TypeError('Could not generate secret')
+      throw new TypeError(
+        `Could not generate secret, args: ${JSON.stringify(
+          recipientOrSenderEpub
+        )} -- ${JSON.stringify(recipientOrSenderSEA)}`
+      )
+    }
+
+    if (sec.length === 0) {
+      throw new TypeError(
+        `SEA.secret returned an empty string!, args: ${JSON.stringify(
+          recipientOrSenderEpub
+        )} -- ${JSON.stringify(recipientOrSenderSEA)}`
+      )
     }
 
     return sec
@@ -237,9 +272,6 @@ const instantiateGun = async () => {
       user._.sea
     ))
   }
-  if (typeof mySecret !== 'string') {
-    throw new TypeError("typeof mySec !== 'string'")
-  }
 
   const _gun = new Gun({
     axe: false,