aiolabs/lnbits
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

feat: unique invoice listeners for extensions (#2250)

Browse source 
changes the `register_invoice_listener` to use a non unique key so you its not possible to have a listeners running twice and throw a warning when trying to.
This commit is contained in:
dni ⚡ 2024-02-20 13:03:29 +01:00 • committed by GitHub
parent 14ae6d8b1a
commit 17b7826753
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

20
lnbits/tasks.py
View file

@ -68,9 +68,15 @@ def register_invoice_listener(send_chan: asyncio.Queue, name: Optional[str] = No
A method intended for extensions (and core/tasks.py) to call when they want to be A method intended for extensions (and core/tasks.py) to call when they want to be
notified about new invoice payments incoming. Will emit all incoming payments. notified about new invoice payments incoming. Will emit all incoming payments.
""" """
name_unique = f"{name or 'no_name'}_{str(uuid.uuid4())[:8]}" if not name:
logger.trace(f"sse: registering invoice listener {name_unique}") # fallback to a random name if extension didn't provide one
invoice_listeners[name_unique] = send_chan name = f"no_name_{str(uuid.uuid4())[:8]}"
if invoice_listeners.get(name):
logger.warning(f"invoice listener `{name}` already exists, replacing it")
logger.trace(f"registering invoice listener `{name}`")
invoice_listeners[name] = send_chan
async def webhook_handler(): async def webhook_handler():
@ -168,10 +174,12 @@ async def invoice_callback_dispatcher(checking_id: str):
""" """
payment = await get_standalone_payment(checking_id, incoming=True) payment = await get_standalone_payment(checking_id, incoming=True)
if payment and payment.is_in: if payment and payment.is_in:
logger.trace(f"sse sending invoice callback for payment {checking_id}") logger.trace(
f"invoice listeners: sending invoice callback for payment {checking_id}"
)
await payment.set_pending(False) await payment.set_pending(False)
for chan_name, send_chan in invoice_listeners.items(): for name, send_chan in invoice_listeners.items():
logger.trace(f"sse sending to chan: {chan_name}") logger.trace(f"invoice listeners: sending to `{name}`")
await send_chan.put(payment) await send_chan.put(payment)