From 36ae851a8d4721e13fd8a97ab12ef75e6506e396 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?dni=20=E2=9A=A1?= Date: Tue, 20 Dec 2022 13:44:14 +0100 Subject: [PATCH] nitpicking vlad :) --- lnbits/extensions/usermanager/crud.py | 8 ++++---- lnbits/extensions/usermanager/views_api.py | 12 ++++-------- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/lnbits/extensions/usermanager/crud.py b/lnbits/extensions/usermanager/crud.py index d7b64dbf..959914f2 100644 --- a/lnbits/extensions/usermanager/crud.py +++ b/lnbits/extensions/usermanager/crud.py @@ -53,7 +53,7 @@ async def get_usermanager_user(user_id: str) -> Optional[User]: return User(**row) if row else None -async def get_usermanager_users(user_id: str) -> list[User]: +async def get_usermanager_users(user_id: str) -> List[User]: rows = await db.fetchall( "SELECT * FROM usermanager.users WHERE admin = ?", (user_id,) ) @@ -94,21 +94,21 @@ async def get_usermanager_wallet(wallet_id: str) -> Optional[Wallet]: return Wallet(**row) if row else None -async def get_usermanager_wallets(admin_id: str) -> list[Wallet]: +async def get_usermanager_wallets(admin_id: str) -> List[Wallet]: rows = await db.fetchall( "SELECT * FROM usermanager.wallets WHERE admin = ?", (admin_id,) ) return [Wallet(**row) for row in rows] -async def get_usermanager_users_wallets(user_id: str) -> list[Wallet]: +async def get_usermanager_users_wallets(user_id: str) -> List[Wallet]: rows = await db.fetchall( """SELECT * FROM usermanager.wallets WHERE "user" = ?""", (user_id,) ) return [Wallet(**row) for row in rows] -async def get_usermanager_wallet_transactions(wallet_id: str) -> list[Payment]: +async def get_usermanager_wallet_transactions(wallet_id: str) -> List[Payment]: return await get_payments( wallet_id=wallet_id, complete=True, pending=False, outgoing=True, incoming=True ) diff --git a/lnbits/extensions/usermanager/views_api.py b/lnbits/extensions/usermanager/views_api.py index 56b5de9a..bd111d49 100644 --- a/lnbits/extensions/usermanager/views_api.py +++ b/lnbits/extensions/usermanager/views_api.py @@ -21,7 +21,7 @@ from .crud import ( get_usermanager_wallet_transactions, get_usermanager_wallets, ) -from .models import CreateUserData, CreateUserWallet, Wallet +from .models import CreateUserData, CreateUserWallet @usermanager_ext.get("/api/v1/users", status_code=HTTPStatus.OK) @@ -32,14 +32,10 @@ async def api_usermanager_users( return [user.dict() for user in await get_usermanager_users(user_id)] -@usermanager_ext.get("/api/v1/users/{user_id}", status_code=HTTPStatus.OK) -async def api_usermanager_user( - user_id, wallet: WalletTypeInfo = Depends(get_key_type) # type: ignore -): +@usermanager_ext.get("/api/v1/users/{user_id}", status_code=HTTPStatus.OK, dependencies=[Depends(get_key_type)]) +async def api_usermanager_user(user_id): user = await get_usermanager_user(user_id) - if not user: - return None - return user.dict() + return user.dict() if user else None @usermanager_ext.post(