Wallets: add cln-rest (#1775)

* receive and pay works

* fix linter issues

* import Paymentstatus from core.models

* fix test real payment

* fix get_payment_status check in lnbits

* fix tests?

* simplify

* refactor AsyncClient

* inline import of get_wallet_class

fixes the previous cyclic import

* invoice stream working

* add notes as a reminder to get rid of labels when cln-rest supports payment_hash

* create Payment dummy classmethod

* remove unnecessary fields from dummy

* fixes tests?

* fix model

* fix cln bug (#1814)

* auth header

* rename cln to corelightning

* add clnrest to admin_ui

* add to clnrest allowed sources

* add allowed sources to .env.example

* allow macaroon files

* add corelightning rest to workflow

* proper env names

* cleanup routine

* log wallet connection errors and fix macaroon clnrest

* print error on connection fails

* clnrest: handle disconnects faster

* fix test use of get_payment_status

* make format

* clnrest: add unhashed_description

* add unhashed_description to test

* description_hash test

* unhashed_description not supported by clnrest

* fix checking_id return in api_payments_create_invoice

* refactor test to use client instead of api_payments

* formatting, some errorlogging

* fix test 1

* fix other tests, paid statuses was missing

* error handling

* revert unnecessary changes (#1854)

* apply review of motorina0

---------

Co-authored-by: jackstar12 <jkranawetter05@gmail.com>
Co-authored-by: jackstar12 <62219658+jackstar12@users.noreply.github.com>
Co-authored-by: dni ⚡ <office@dnilabs.com>

tests/core/views/test_api.py

@@ -305,26 +305,30 @@ async def test_api_payment_with_key(invoice, inkey_headers_from):
 
 # check POST /api/v1/payments: invoice creation with a description hash
 @pytest.mark.skipif(
-    WALLET.__class__.__name__ in ["CoreLightningWallet"],
+    WALLET.__class__.__name__ in ["CoreLightningWallet", "CoreLightningRestWallet"],
     reason="wallet does not support description_hash",
 )
 @pytest.mark.asyncio
 async def test_create_invoice_with_description_hash(client, inkey_headers_to):
     data = await get_random_invoice_data()
-    descr_hash = hashlib.sha256("asdasdasd".encode()).hexdigest()
+    description = "asdasdasd"
+    descr_hash = hashlib.sha256(description.encode()).hexdigest()
     data["description_hash"] = descr_hash
-
+    data["unhashed_description"] = description.encode().hex()
     response = await client.post(
         "/api/v1/payments", json=data, headers=inkey_headers_to
     )
     invoice = response.json()
-
     invoice_bolt11 = bolt11.decode(invoice["payment_request"])
+
     assert invoice_bolt11.description_hash == descr_hash
-    assert invoice_bolt11.description is None
     return invoice
 
 
+@pytest.mark.skipif(
+    WALLET.__class__.__name__ in ["CoreLightningRestWallet"],
+    reason="wallet does not support unhashed_description",
+)
 @pytest.mark.asyncio
 async def test_create_invoice_with_unhashed_description(client, inkey_headers_to):
     data = await get_random_invoice_data()
@@ -367,10 +371,12 @@ async def test_pay_real_invoice(
     assert payment.payment_hash == invoice["payment_hash"]
 
     # check the payment status
-    response = await api_payment(
-        invoice["payment_hash"], inkey_headers_from["X-Api-Key"]
+    response = await client.get(
+        f'/api/v1/payments/{invoice["payment_hash"]}', headers=inkey_headers_from
     )
-    assert response["paid"]
+    assert response.status_code < 300
+    payment_status = response.json()
+    assert payment_status["paid"]
 
     status = await WALLET.get_payment_status(invoice["payment_hash"])
     assert status.paid
@@ -392,23 +398,32 @@ async def test_create_real_invoice(client, adminkey_headers_from, inkey_headers_
     )
     assert response.status_code < 300
     invoice = response.json()
-    response = await api_payment(
-        invoice["payment_hash"], inkey_headers_from["X-Api-Key"]
+
+    response = await client.get(
+        f'/api/v1/payments/{invoice["payment_hash"]}', headers=inkey_headers_from
     )
-    assert not response["paid"]
+    assert response.status_code < 300
+    payment_status = response.json()
+    assert not payment_status["paid"]
 
     async def listen():
-        async for payment_hash in get_wallet_class().paid_invoices_stream():
-            assert payment_hash == invoice["payment_hash"]
-            return
+        found_checking_id = False
+        async for checking_id in get_wallet_class().paid_invoices_stream():
+            if checking_id == invoice["checking_id"]:
+                found_checking_id = True
+                return
+        assert found_checking_id
 
     task = asyncio.create_task(listen())
     pay_real_invoice(invoice["payment_request"])
     await asyncio.wait_for(task, timeout=3)
-    response = await api_payment(
-        invoice["payment_hash"], inkey_headers_from["X-Api-Key"]
+
+    response = await client.get(
+        f'/api/v1/payments/{invoice["payment_hash"]}', headers=inkey_headers_from
     )
-    assert response["paid"]
+    assert response.status_code < 300
+    payment_status = response.json()
+    assert payment_status["paid"]
 
     await asyncio.sleep(0.3)
     balance = await get_node_balance_sats()
@@ -442,6 +457,7 @@ async def test_pay_real_invoice_set_pending_and_check_state(
     )
     assert response["paid"]
 
+    # make sure that the backend also thinks it's paid
     status = await WALLET.get_payment_status(invoice["payment_hash"])
     assert status.paid
 
@@ -618,8 +634,8 @@ async def test_receive_real_invoice_set_pending_and_check_state(
     assert not response["paid"]
 
     async def listen():
-        async for payment_hash in get_wallet_class().paid_invoices_stream():
-            assert payment_hash == invoice["payment_hash"]
+        async for checking_id in get_wallet_class().paid_invoices_stream():
+            assert checking_id == invoice["checking_id"]
             return
 
     task = asyncio.create_task(listen())