refactor: simplify if+for

This commit is contained in:
Vlad Stan 2023-01-20 18:00:50 +02:00
parent e95c6ec3a6
commit 5212320d8d

View file

@ -326,8 +326,8 @@ class InstallableExtension(BaseModel):
try: try:
error_msg = "Cannot fetch extensions manifest" error_msg = "Cannot fetch extensions manifest"
manifest = await gihub_api_get(url, error_msg) manifest = await gihub_api_get(url, error_msg)
if "repos" in manifest:
for r in manifest["repos"]: for r in manifest.get("repos", []):
if r["id"] in extension_id_list: if r["id"] in extension_id_list:
continue continue
ext = await InstallableExtension.from_repo( ext = await InstallableExtension.from_repo(
@ -337,8 +337,7 @@ class InstallableExtension(BaseModel):
extension_list += [ext] extension_list += [ext]
extension_id_list += [ext.id] extension_id_list += [ext.id]
if "extensions" in manifest: for e in manifest.get("extensions", []):
for e in manifest["extensions"]:
if e["id"] in extension_id_list: if e["id"] in extension_id_list:
continue continue
extension_list += [InstallableExtension.from_manifest(e)] extension_list += [InstallableExtension.from_manifest(e)]