From 5dbd9a91926d50008b0c4b67060261667ca41dcf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?dni=20=E2=9A=A1?= <office@dnilabs.com>
Date: Mon, 3 Apr 2023 12:23:01 +0200
Subject: [PATCH] add some assert description

---
 Makefile                | 2 +-
 lnbits/core/crud.py     | 4 ++--
 lnbits/core/services.py | 4 ++--
 lnbits/wallets/spark.py | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index 0f4f83bb..25add4fc 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 .PHONY: test
 
-all: format check requirements.txt
+all: format check
 
 format: prettier isort black
 
diff --git a/lnbits/core/crud.py b/lnbits/core/crud.py
index 73656c7c..e51b7403 100644
--- a/lnbits/core/crud.py
+++ b/lnbits/core/crud.py
@@ -718,7 +718,7 @@ async def update_admin_settings(data: EditableSettings):
 async def update_super_user(super_user: str) -> SuperSettings:
     await db.execute("UPDATE settings SET super_user = ?", (super_user,))
     settings = await get_super_settings()
-    assert settings
+    assert settings, "updated super_user settings could not be retrieved"
     return settings
 
 
@@ -726,7 +726,7 @@ async def create_admin_settings(super_user: str, new_settings: dict):
     sql = "INSERT INTO settings (super_user, editable_settings) VALUES (?, ?)"
     await db.execute(sql, (super_user, json.dumps(new_settings)))
     settings = await get_super_settings()
-    assert settings
+    assert settings, "created admin settings could not be retrieved"
     return settings
 
 
diff --git a/lnbits/core/services.py b/lnbits/core/services.py
index 4675ee24..9b699571 100644
--- a/lnbits/core/services.py
+++ b/lnbits/core/services.py
@@ -184,7 +184,7 @@ async def pay_invoice(
 
         # do the balance check
         wallet = await get_wallet(wallet_id, conn=conn)
-        assert wallet
+        assert wallet, "Wallet for balancecheck could not be fetched"
         if wallet.balance_msat < 0:
             logger.debug("balance is too low, deleting temporary payment")
             if not internal_checking_id and wallet.balance_msat > -fee_reserve_msat:
@@ -362,7 +362,7 @@ async def perform_lnurlauth(
     sig = key.sign_digest_deterministic(k1, sigencode=encode_strict_der)
 
     async with httpx.AsyncClient() as client:
-        assert key.verifying_key
+        assert key.verifying_key, "LNURLauth verifying_key does not exist"
         r = await client.get(
             callback,
             params={
diff --git a/lnbits/wallets/spark.py b/lnbits/wallets/spark.py
index a130becb..1a4067a8 100644
--- a/lnbits/wallets/spark.py
+++ b/lnbits/wallets/spark.py
@@ -28,7 +28,7 @@ class UnknownError(Exception):
 
 class SparkWallet(Wallet):
     def __init__(self):
-        assert settings.spark_url
+        assert settings.spark_url, "spark url does not exist"
         self.url = settings.spark_url.replace("/rpc", "")
         self.token = settings.spark_token
 
@@ -47,7 +47,7 @@ class SparkWallet(Wallet):
 
             try:
                 async with httpx.AsyncClient() as client:
-                    assert self.token
+                    assert self.token, "spark wallet token does not exist"
                     r = await client.post(
                         self.url + "/rpc",
                         headers={"X-Access": self.token},