feat: improve on create wallet frontend and api. (BREAKING CHANGE) (#3635)

2025-12-08 11:09:43 +01:00 · 2025-12-08 11:09:43 +01:00 · 5f86627eae
commit 5f86627eae
parent 3af3838995
13 changed files with 101 additions and 71 deletions
--- a/lnbits/core/views/wallet_api.py
+++ b/lnbits/core/views/wallet_api.py
@ -197,11 +197,14 @@ async def api_delete_wallet(

@wallet_router.post("")
 async def api_create_wallet(
-    data: CreateWallet,
-    key_info: WalletTypeInfo = Depends(require_admin_key),
+    data: CreateWallet, account_id: AccountId = Depends(check_account_id_exists)
 ) -> Wallet:
-    if data.wallet_type == WalletType.LIGHTNING:
-        return await create_wallet(user_id=key_info.wallet.user, wallet_name=data.name)
+
+    if data.wallet_type not in list(WalletType):
+        raise HTTPException(
+            HTTPStatus.BAD_REQUEST,
+            f"Wallet type {data.wallet_type} does not exist.",
+        )

    if data.wallet_type == WalletType.LIGHTNING_SHARED:
        if not data.shared_wallet_id:
@ -210,11 +213,9 @@ async def api_create_wallet(
                "Shared wallet ID is required for shared wallets.",
            )
        return await create_lightning_shared_wallet(
-            user_id=key_info.wallet.user,
+            user_id=account_id.id,
            source_wallet_id=data.shared_wallet_id,
        )

-    raise HTTPException(
-        HTTPStatus.BAD_REQUEST,
-        f"Unknown wallet type: {data.wallet_type}.",
-    )
+    # default WalletType.LIGHTNING:
+    return await create_wallet(user_id=account_id.id, wallet_name=data.name)
--- a/lnbits/static/bundle-components.min.js
+++ b/lnbits/static/bundle-components.min.js
--- a/lnbits/static/bundle.min.js
+++ b/lnbits/static/bundle.min.js
--- a/lnbits/static/js/api.js
+++ b/lnbits/static/js/api.js
@ -129,14 +129,12 @@ window._lnbitsApi = {
  getWallet(wallet) {
    return this.request('get', '/api/v1/wallet', wallet.inkey)
  },
-  createWallet(wallet, name, walletType, ops = {}) {
-    return this.request('post', '/api/v1/wallet', wallet.adminkey, {
+  createWallet(name, walletType, opts = {}) {
+    return this.request('post', '/api/v1/wallet', null, {
      name: name,
      wallet_type: walletType,
-      ...ops
-    }).then(res => {
-      window.location = '/wallet?wal=' + res.data.id
-    })
+      ...opts
+    }).catch(LNbits.utils.notifyApiError)
  },
  updateWallet(name, wallet) {
    return this.request('patch', '/api/v1/wallet', wallet.adminkey, {
--- a/lnbits/static/js/components/lnbits-manage-wallet-list.js
+++ b/lnbits/static/js/components/lnbits-manage-wallet-list.js
@ -26,6 +26,13 @@ window.app.component('lnbits-manage-wallet-list', {
    }
  },
  methods: {
+    openNewWalletDialog() {
+      if (this.g.user.walletInvitesCount) {
+        this.g.newWalletType = 'lightning-shared'
+      } else {
+        this.g.newWalletType = 'lightning'
+      }
+    },
    onWebsocketMessage(ev) {
      const data = JSON.parse(ev.data)
      if (!data.payment) {
--- a/lnbits/static/js/components/lnbits-wallet-new.js
+++ b/lnbits/static/js/components/lnbits-wallet-new.js
@ -4,10 +4,27 @@ window.app.component('lnbits-wallet-new', {
  data() {
    return {
      walletTypes: [{label: 'Lightning Wallet', value: 'lightning'}],
-      newWallet: {name: '', sharedWalletId: ''}
+      wallet: {name: '', sharedWalletId: ''},
+      showNewWalletDialog: false
+    }
+  },
+  watch: {
+    'g.newWalletType'(val) {
+      if (val === null) return
+      this.showNewWalletDialog = true
+    },
+    showNewWalletDialog(val) {
+      if (val === true) return
+      this.reset()
    }
  },
  computed: {
+    isLightning() {
+      return this.g.newWalletType === 'lightning'
+    },
+    isLightningShared() {
+      return this.g.newWalletType === 'lightning-shared'
+    },
    inviteWalletOptions() {
      return (this.g.user?.extra?.wallet_invite_requests || []).map(i => ({
        label: `${i.to_wallet_name} (from ${i.from_user_name})`,
@ -16,11 +33,16 @@ window.app.component('lnbits-wallet-new', {
    }
  },
  methods: {
+    reset() {
+      this.showNewWalletDialog = false
+      this.g.newWalletType = null
+      this.wallet = {name: '', sharedWalletId: ''}
+    },
    async submitRejectWalletInvitation() {
      try {
        const inviteRequests = this.g.user.extra.wallet_invite_requests || []
        const invite = inviteRequests.find(
-          invite => invite.to_wallet_id === this.newWallet.sharedWalletId
+          invite => invite.to_wallet_id === this.wallet.sharedWalletId
        )
        if (!invite) {
          Quasar.Notify.create({
@ -46,8 +68,8 @@ window.app.component('lnbits-wallet-new', {
        LNbits.utils.notifyApiError(err)
      }
    },
-    async submitAddWallet() {
-      const data = this.newWallet
+    submitAddWallet() {
+      const data = this.wallet
      if (this.g.newWalletType === 'lightning' && !data.name) {
        this.$q.notify({
          message: 'Please enter a name for the wallet',
@ -55,7 +77,6 @@ window.app.component('lnbits-wallet-new', {
        })
        return
      }
-
      if (this.g.newWalletType === 'lightning-shared' && !data.sharedWalletId) {
        this.$q.notify({
          message: 'Missing a shared wallet ID',
@ -63,19 +84,20 @@ window.app.component('lnbits-wallet-new', {
        })
        return
      }
-      try {
-        await LNbits.api.createWallet(
-          this.g.user.wallets[0],
-          data.name,
-          this.g.newWalletType,
-          {
-            shared_wallet_id: data.sharedWalletId
-          }
-        )
-      } catch (e) {
-        console.warn(e)
-        LNbits.utils.notifyApiError(e)
-      }
+      LNbits.api
+        .createWallet(data.name, this.g.newWalletType, {
+          shared_wallet_id: data.sharedWalletId
+        })
+        .then(res => {
+          this.$q.notify({
+            message: 'Wallet created successfully',
+            color: 'positive'
+          })
+          this.reset()
+          this.g.user.wallets.push(LNbits.map.wallet(res.data))
+          this.g.lastWalletId = res.data.id
+          this.$router.push(`/wallet/${res.data.id}`)
+        })
    }
  },
  created() {
--- a/lnbits/static/js/globals.js
+++ b/lnbits/static/js/globals.js
@ -24,8 +24,6 @@ window.g = Vue.reactive({
  fiatTracking: false,
  payments: [],
  walletEventListeners: [],
-  showNewWalletDialog: false,
-  newWalletType: 'lightning',
  updatePayments: false, // used for updating the lnbits-payment-list
  updatePaymentsHash: false, // used for closing the receive dialog
  currencies: WINDOW_SETTINGS.LNBITS_CURRENCIES ?? [],
@ -57,7 +55,8 @@ window.g = Vue.reactive({
  ads: WINDOW_SETTINGS.AD_SPACE.split(',').map(ad => ad.split(';')),
  denomination: WINDOW_SETTINGS.LNBITS_DENOMINATION,
  isSatsDenomination: WINDOW_SETTINGS.LNBITS_DENOMINATION == 'sats',
-  scanner: null
+  scanner: null,
+  newWalletType: null
 })

 window.dateFormat = 'YYYY-MM-DD HH:mm'
--- a/lnbits/static/js/windowMixin.js
+++ b/lnbits/static/js/windowMixin.js
@ -1,8 +1 @@
-window.windowMixin = {
-  methods: {
-    openNewWalletDialog(walletType = 'lightning') {
-      this.g.newWalletType = walletType
-      this.g.showNewWalletDialog = true
-    }
-  }
-}
+window.windowMixin = {}
--- a/lnbits/templates/components/lnbits-header-wallets.vue
+++ b/lnbits/templates/components/lnbits-header-wallets.vue
@ -18,7 +18,7 @@
        <q-card-section class="flex flex-center column full-height text-center">
          <div>
            <q-btn
-              @click="openNewWalletDialog()"
+              @click="g.newWalletType = 'lightning'"
              round
              color="primary"
              icon="add"
@ -29,7 +29,7 @@
          <div>
            <q-badge
              v-if="g.user.walletInvitesCount"
-              @click="openNewWalletDialog('lightning-shared')"
+              @click="g.newWalletType = 'lightning-shared'"
              dense
              outline
              class="q-mt-sm"
--- a/lnbits/templates/components/lnbits-manage-wallet-list.vue
+++ b/lnbits/templates/components/lnbits-manage-wallet-list.vue
@ -61,14 +61,7 @@
        ></q-item-label>
      </q-item-section>
    </q-item>
-    <q-item
-      clickable
-      @click="
-        g.user.walletInvitesCount
-          ? openNewWalletDialog('lightning-shared')
-          : openNewWalletDialog('lightning')
-      "
-    >
+    <q-item clickable @click="openNewWalletDialog">
      <q-item-section side>
        <q-icon name="add" color="grey-5" size="md"></q-icon>
      </q-item-section>
--- a/lnbits/templates/components/lnbits-wallet-new.vue
+++ b/lnbits/templates/components/lnbits-wallet-new.vue
@ -1,5 +1,5 @@
 <template id="lnbits-wallet-new">
-  <q-dialog v-model="g.showNewWalletDialog" position="top">
+  <q-dialog v-model="showNewWalletDialog" position="top">
    <q-card class="q-pa-lg q-pt-md lnbits__dialog-card">
      <q-card-section>
        <div class="text-h6">
@ -33,18 +33,17 @@
          dense
        ></q-select>
        <q-input
-          v-if="g.newWalletType == 'lightning'"
+          v-if="isLightning"
          dense
-          v-model="newWallet.name"
+          v-model="wallet.name"
          :label="$t('wallet_name')"
          autofocus
          @keyup.enter="submitAddWallet()"
          class="q-mt-md"
        ></q-input>
-
        <q-select
-          v-if="g.newWalletType == 'lightning-shared'"
-          v-model="newWallet.sharedWalletId"
+          v-if="isLightningShared"
+          v-model="wallet.sharedWalletId"
          :label="$t('shared_wallet_id')"
          emit-value
          map-options
@ -52,7 +51,7 @@
          :options="inviteWalletOptions"
          class="q-mt-md"
        ></q-select>
-        <div v-if="g.newWalletType == 'lightning-shared'" class="q-mt-md">
+        <div v-if="isLightningShared" class="q-mt-md">
          <span v-text="$t('shared_wallet_desc')" class="q-mt-lg"></span>
        </div>
      </q-card-section>
@ -69,8 +68,8 @@
          </div>
          <div class="col-md-4">
            <q-btn
-              v-if="g.newWalletType == 'lightning-shared'"
-              :disabled="!newWallet.sharedWalletId"
+              v-if="isLightningShared"
+              :disabled="!wallet.sharedWalletId"
              flat
              :label="$t('reject_wallet')"
              v-close-popup
--- a/lnbits/templates/pages/wallets.vue
+++ b/lnbits/templates/pages/wallets.vue
@ -6,7 +6,7 @@
          <div class="row items-center justify-between q-gutter-xs">
            <div class="col">
              <q-btn
-                @click="openNewWalletDialog()"
+                @click="g.newWalletType = 'lightning'"
                :label="$t('add_wallet')"
                color="primary"
              >
--- a/tests/api/test_api.py
+++ b/tests/api/test_api.py
@ -44,11 +44,28 @@ async def test_create_account(client, settings: Settings):
 # check POST and DELETE /api/v1/wallet with adminkey and user token:
 # create additional wallet and delete it
@pytest.mark.anyio
-async def test_create_wallet_and_delete(
-    client, adminkey_headers_from, user_headers_from
-):
+async def test_create_wallet_and_delete(client, user_headers_from):
+    tiny_id = shortuuid.uuid()[:8]
    response = await client.post(
-        "/api/v1/wallet", json={"name": "test"}, headers=adminkey_headers_from
+        "/api/v1/auth/register",
+        json={
+            "username": f"u21.{tiny_id}",
+            "password": "secret1234",
+            "password_repeat": "secret1234",
+            "email": f"u21.{tiny_id}@lnbits.com",
+        },
+    )
+
+    client.cookies.clear()
+
+    access_token = response.json().get("access_token")
+    assert response.status_code == 200, "User created."
+    assert response.json().get("access_token") is not None
+
+    response = await client.post(
+        "/api/v1/wallet",
+        json={"name": "test"},
+        headers={"Authorization": f"Bearer {access_token}"},
    )
    assert response.status_code == 200
    result = response.json()
@ -58,6 +75,7 @@ async def test_create_wallet_and_delete(
    assert "id" in result
    assert "adminkey" in result

+    # should not work with admin key only with user
    invalid_response = await client.delete(
        f"/api/v1/wallet/{result['id']}",
        headers={
@ -69,7 +87,7 @@ async def test_create_wallet_and_delete(

    response = await client.delete(
        f"/api/v1/wallet/{result['id']}",
-        headers=user_headers_from,
+        headers={"Authorization": f"Bearer {access_token}"},
    )
    assert response.status_code == 200