aiolabs/lnbits
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: clean upgrades folder on uninstall

Browse source
This commit is contained in:
Vlad Stan 2023-01-11 16:05:34 +02:00
parent e3ee04edc7
commit 9d0fba7c15
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lnbits/extension_manger.py
View file

@ -123,6 +123,10 @@ class InstallableExtension(NamedTuple):
def ext_dir(self) -> str: def ext_dir(self) -> str:
return os.path.join("lnbits", "extensions", self.id) return os.path.join("lnbits", "extensions", self.id)
@property
def ext_upgrade_dir(self) -> str:
return os.path.join("lnbits", "upgrades", f"{self.id}-{self.hash}")
@property @property
def module_name(self) -> str: def module_name(self) -> str:
return f"lnbits.extensions.{self.id}" return f"lnbits.extensions.{self.id}"
@ -159,11 +163,10 @@ class InstallableExtension(NamedTuple):
with zipfile.ZipFile(self.zip_path, "r") as zip_ref: with zipfile.ZipFile(self.zip_path, "r") as zip_ref:
zip_ref.extractall(os.path.join("lnbits", "extensions")) zip_ref.extractall(os.path.join("lnbits", "extensions"))
ext_upgrade_dir = os.path.join("lnbits", "upgrades", f"{self.id}-{self.hash}")
os.makedirs(os.path.join("lnbits", "upgrades"), exist_ok=True) os.makedirs(os.path.join("lnbits", "upgrades"), exist_ok=True)
shutil.rmtree(ext_upgrade_dir, True) shutil.rmtree(self.ext_upgrade_dir, True)
with zipfile.ZipFile(self.zip_path, "r") as zip_ref: with zipfile.ZipFile(self.zip_path, "r") as zip_ref:
zip_ref.extractall(ext_upgrade_dir) zip_ref.extractall(self.ext_upgrade_dir)
def nofiy_upgrade(self) -> None: def nofiy_upgrade(self) -> None:
"""Update the the list of upgraded extensions. The middleware will perform redirects based on this""" """Update the the list of upgraded extensions. The middleware will perform redirects based on this"""
@ -172,7 +175,7 @@ class InstallableExtension(NamedTuple):
clean_upgraded_exts = list( clean_upgraded_exts = list(
filter( filter(
lambda old_ext: old_ext.endswith(f"/{self.id}"), lambda old_ext: not old_ext.endswith(f"/{self.id}"),
settings.lnbits_upgraded_extensions, settings.lnbits_upgraded_extensions,
) )
) )
@ -188,6 +191,8 @@ class InstallableExtension(NamedTuple):
# remove module from extensions # remove module from extensions
shutil.rmtree(self.ext_dir, True) shutil.rmtree(self.ext_dir, True)
shutil.rmtree(self.ext_upgrade_dir, True)
@classmethod @classmethod
async def get_extension_info(cls, ext_id: str, hash: str) -> "InstallableExtension": async def get_extension_info(cls, ext_id: str, hash: str) -> "InstallableExtension":
installable_extensions: List[ installable_extensions: List[