aiolabs/lnbits
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Fix login logout on safari (#2309)

Browse source 
* fix: relax security level for public cookies

* fix: corner case for logout
This commit is contained in:
Vlad Stan 2024-03-07 11:22:42 +02:00 • committed by GitHub
parent 884a1b9d6f
commit cb5c9b03bf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lnbits/app.py
View file

@ -535,9 +535,7 @@ def register_exception_handlers(app: FastAPI):
response = RedirectResponse("/") response = RedirectResponse("/")
response.delete_cookie("cookie_access_token") response.delete_cookie("cookie_access_token")
response.delete_cookie("is_lnbits_user_authorized") response.delete_cookie("is_lnbits_user_authorized")
response.set_cookie( response.set_cookie("is_access_token_expired", "true")
"is_access_token_expired", "true", samesite="none", secure=True
)
return response return response
return template_renderer().TemplateResponse( return template_renderer().TemplateResponse(

10
lnbits/core/views/auth_api.py
View file

@ -142,6 +142,8 @@ async def logout() -> JSONResponse:
response.delete_cookie("cookie_access_token") response.delete_cookie("cookie_access_token")
response.delete_cookie("is_lnbits_user_authorized") response.delete_cookie("is_lnbits_user_authorized")
response.delete_cookie("is_access_token_expired") response.delete_cookie("is_access_token_expired")
response.delete_cookie("lnbits_last_active_wallet")
return response return response
@ -286,9 +288,7 @@ def _auth_success_response(
) )
response = JSONResponse({"access_token": access_token, "token_type": "bearer"}) response = JSONResponse({"access_token": access_token, "token_type": "bearer"})
response.set_cookie("cookie_access_token", access_token, httponly=True) response.set_cookie("cookie_access_token", access_token, httponly=True)
response.set_cookie( response.set_cookie("is_lnbits_user_authorized", "true")
"is_lnbits_user_authorized", "true", samesite="none", secure=True
)
response.delete_cookie("is_access_token_expired") response.delete_cookie("is_access_token_expired")
return response return response
@ -298,9 +298,7 @@ def _auth_redirect_response(path: str, email: str) -> RedirectResponse:
access_token = create_access_token(data={"sub": "" or "", "email": email}) access_token = create_access_token(data={"sub": "" or "", "email": email})
response = RedirectResponse(path) response = RedirectResponse(path)
response.set_cookie("cookie_access_token", access_token, httponly=True) response.set_cookie("cookie_access_token", access_token, httponly=True)
response.set_cookie( response.set_cookie("is_lnbits_user_authorized", "true")
"is_lnbits_user_authorized", "true", samesite="none", secure=True
)
response.delete_cookie("is_access_token_expired") response.delete_cookie("is_access_token_expired")
return response return response

4
lnbits/core/views/generic.py
View file

@ -221,9 +221,7 @@ async def wallet(
"web_manifest": f"/manifest/{user.id}.webmanifest", "web_manifest": f"/manifest/{user.id}.webmanifest",
}, },
) )
resp.set_cookie( resp.set_cookie("lnbits_last_active_wallet", wallet_id)
"lnbits_last_active_wallet", wallet_id, samesite="none", secure=True
)
return resp return resp