fix(ui): correct amountless invoice detection in bolt11 decoder
Some checks failed
LNbits CI / lint (push) Waiting to run
LNbits CI / test-api (, 3.10) (push) Blocked by required conditions
LNbits CI / test-api (, 3.11) (push) Blocked by required conditions
LNbits CI / test-api (, 3.12) (push) Blocked by required conditions
LNbits CI / test-api (postgres://lnbits:lnbits@0.0.0.0:5432/lnbits, 3.10) (push) Blocked by required conditions
LNbits CI / test-api (postgres://lnbits:lnbits@0.0.0.0:5432/lnbits, 3.11) (push) Blocked by required conditions
LNbits CI / test-api (postgres://lnbits:lnbits@0.0.0.0:5432/lnbits, 3.12) (push) Blocked by required conditions
LNbits CI / test-wallets (, 3.10) (push) Blocked by required conditions
LNbits CI / test-wallets (, 3.11) (push) Blocked by required conditions
LNbits CI / test-wallets (, 3.12) (push) Blocked by required conditions
LNbits CI / test-wallets (postgres://lnbits:lnbits@0.0.0.0:5432/lnbits, 3.10) (push) Blocked by required conditions
LNbits CI / test-wallets (postgres://lnbits:lnbits@0.0.0.0:5432/lnbits, 3.11) (push) Blocked by required conditions
LNbits CI / test-wallets (postgres://lnbits:lnbits@0.0.0.0:5432/lnbits, 3.12) (push) Blocked by required conditions
LNbits CI / test-unit (, 3.10) (push) Blocked by required conditions
LNbits CI / test-unit (, 3.11) (push) Blocked by required conditions
LNbits CI / test-unit (, 3.12) (push) Blocked by required conditions
LNbits CI / test-unit (postgres://lnbits:lnbits@0.0.0.0:5432/lnbits, 3.10) (push) Blocked by required conditions
LNbits CI / test-unit (postgres://lnbits:lnbits@0.0.0.0:5432/lnbits, 3.11) (push) Blocked by required conditions
LNbits CI / test-unit (postgres://lnbits:lnbits@0.0.0.0:5432/lnbits, 3.12) (push) Blocked by required conditions
LNbits CI / migration (3.10) (push) Blocked by required conditions
LNbits CI / migration (3.11) (push) Blocked by required conditions
LNbits CI / migration (3.12) (push) Blocked by required conditions
LNbits CI / openapi (push) Blocked by required conditions
LNbits CI / regtest (BoltzWallet, 3.10) (push) Blocked by required conditions
LNbits CI / regtest (CoreLightningRestWallet, 3.10) (push) Blocked by required conditions
LNbits CI / regtest (CoreLightningWallet, 3.10) (push) Blocked by required conditions
LNbits CI / regtest (EclairWallet, 3.10) (push) Blocked by required conditions
LNbits CI / regtest (LNbitsWallet, 3.10) (push) Blocked by required conditions
LNbits CI / regtest (LndRestWallet, 3.10) (push) Blocked by required conditions
LNbits CI / regtest (LndWallet, 3.10) (push) Blocked by required conditions
LNbits CI / jmeter (3.10) (push) Blocked by required conditions
codeql / analyze (push) Waiting to run
LNbits CI / nix / nix (push) Has been cancelled

The bolt11 decoder returns the string 'Any amount' for amountless
invoices, not null or 0. The previous check failed because non-empty
strings are truthy in JavaScript.

Changed detection from:
  !amount || amount === 0
To:
  typeof amount !== 'number' || amount <= 0

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Patrick Mulligan 2026-01-10 02:27:33 +01:00 committed by padreug
parent 71a94766b1
commit e4eafa4528

View file

@ -308,16 +308,17 @@ window.PageWallet = {
}
// Check if invoice is amountless (no amount specified)
// The decoder returns 'Any amount' string for amountless invoices
const invoiceAmount = invoice.human_readable_part.amount
const isAmountless =
!invoice.human_readable_part.amount ||
invoice.human_readable_part.amount === 0
typeof invoiceAmount !== 'number' || invoiceAmount <= 0
let cleanInvoice = {
msat: isAmountless ? null : invoice.human_readable_part.amount,
sat: isAmountless ? null : invoice.human_readable_part.amount / 1000,
msat: isAmountless ? null : invoiceAmount,
sat: isAmountless ? null : invoiceAmount / 1000,
fsat: isAmountless
? this.$t('any_amount')
: LNbits.utils.formatSat(invoice.human_readable_part.amount / 1000),
: LNbits.utils.formatSat(invoiceAmount / 1000),
bolt11: this.parse.data.request,
isAmountless: isAmountless
}