From 4017706c1880bc2d59d0c8fdaa04249fbd597b79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?dni=20=E2=9A=A1?= Date: Fri, 24 Nov 2023 13:15:55 +0100 Subject: [PATCH] hotfix: lnaddress are broken (#34) lnurl validation error. ``` pydantic.error_wrappers.ValidationError: 2 validation errors for LnurlPayResponse callback URL invalid, extra characters found after valid URL: ' extra={}' (type=value_error.url.extra; extra= extra={}) callback URL invalid, extra characters found after valid URL: ' extra={}' (type=value_error.url.extra; extra= extra={}) 2023-11-24 12:54:05.36 | ERROR | lnbits.app:exception_handler:467 | Exception: 2 validation errors for LnurlPayResponse callback URL invalid, extra characters found after valid URL: ' extra={}' (type=value_error.url.extra; extra= extra={}) callback URL invalid, extra characters found after valid URL: ' extra={}' (type=value_error.url.extra; extra= extra={}) 2023-11-24 12:54:05.36 | INFO | 52.57.61.135:0 - "GET /lnurlp/api/v1/well-known/test HTTP/1.1" 500 ``` --- lnurl.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lnurl.py b/lnurl.py index c461595..485c779 100644 --- a/lnurl.py +++ b/lnurl.py @@ -39,7 +39,7 @@ async def api_lnurl_callback( link_id, amount: int = Query(...), webhook_data: str = Query(None), - lnaddress=False, + lnaddress: bool = False, ): link = await increment_pay_link(link_id, served_pr=1) if not link: @@ -152,6 +152,7 @@ async def api_lnurl_response( request.url_for( "lnurlp.api_lnurl_lnaddr_callback", link_id=link.id, + webhook_data=webhook_data, ) ) else: @@ -159,12 +160,10 @@ async def api_lnurl_response( request.url_for( "lnurlp.api_lnurl_callback", link_id=link.id, + webhook_data=webhook_data, ) ) - if webhook_data: - callback += f"?webhook_data={webhook_data}" - resp = LnurlPayResponse( callback=callback, min_sendable=round(link.min * rate) * 1000, # type: ignore