aiolabs/nix-bitcoin
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

refactor(lamassu): remove redundant pnpm rebuild step
Some checks failed
nix-bitcoin tests / build_test_drivers (push) Has been cancelled
Details
nix-bitcoin tests / check_flake (push) Has been cancelled
Details
nix-bitcoin tests / test_scenario (default) (push) Has been cancelled
Details
nix-bitcoin tests / test_scenario (joinmarket-bitcoind-29) (push) Has been cancelled
Details
nix-bitcoin tests / test_scenario (netns) (push) Has been cancelled
Details
nix-bitcoin tests / test_scenario (netnsRegtest) (push) Has been cancelled
Details

Browse source 
pnpm rebuild always fails due to signal handling issues and we
ignore the failure anyway. Since we explicitly rebuild the
problematic native modules (node-expat, iconv, argon2), the
pnpm rebuild step is unnecessary.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Patrick Mulligan 2026-01-09 23:33:37 +01:00
parent 3d45dcadbd
commit 3b39918c38
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
modules/lamassu-lnbits.nix
View file

@ -317,11 +317,10 @@ in
[ "$NEEDS_BUILD" = "0" ] && exit 0 [ "$NEEDS_BUILD" = "0" ] && exit 0
# Install and build # Install dependencies (without running install scripts)
pnpm install --no-frozen-lockfile --ignore-scripts pnpm install --no-frozen-lockfile --ignore-scripts
pnpm rebuild || true
# Rebuild problematic native modules # Build native modules explicitly (pnpm rebuild has signal handling issues)
for module in node-expat iconv; do for module in node-expat iconv; do
path=$(find node_modules/.pnpm -name "$module" -type d -path "*/$module" 2>/dev/null | head -1) path=$(find node_modules/.pnpm -name "$module" -type d -path "*/$module" 2>/dev/null | head -1)
[ -n "$path" ] && [ -f "$path/binding.gyp" ] && (cd "$path" && npx node-gyp rebuild) || true [ -n "$path" ] && [ -f "$path/binding.gyp" ] && (cd "$path" && npx node-gyp rebuild) || true