From 815f2cd325ef2abebb596de1ac453014d5cb4ff6 Mon Sep 17 00:00:00 2001
From: Erik Arvstedt <erik.arvstedt@gmail.com>
Date: Fri, 9 May 2025 13:31:19 +0200
Subject: [PATCH] clightning: don't set `datadir` for `bitcoin-cli` plugin

This option is unneeded because `bitcoin-cli` auth and connection
settings are already provided by other options like `bitcoin-rpcpassword`.

In bitcoind versions prior to 29.0, option `datadir` (passed by clightning to `bitcoin-cli`)
was therefore ignored.
Since 29.0, option `datadir` is always checked for validity. This causes a
file permission error because service clighting has no access to the
bitcoin datadir. This is now fixed.
---
 modules/clightning.nix | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/modules/clightning.nix b/modules/clightning.nix
index 766e2ce..b8fd064 100644
--- a/modules/clightning.nix
+++ b/modules/clightning.nix
@@ -116,13 +116,7 @@ let
   network = bitcoind.makeNetworkName "bitcoin" "regtest";
   configFile = pkgs.writeText "config" ''
     network=${network}
-    ${
-      if cfg.useBcliPlugin then ''
-        bitcoin-datadir=${config.services.bitcoind.dataDir}
-      '' else ''
-        disable-plugin=bcli
-      ''
-    }
+    ${optionalString (!cfg.useBcliPlugin) "disable-plugin=bcli"}
     ${optionalString (cfg.proxy != null) "proxy=${cfg.proxy}"}
     always-use-proxy=${boolToString cfg.always-use-proxy}
     bind-addr=${cfg.address}:${toString cfg.port}