From 8ee71833b985239fb496e452c51a70ac9c1e59f0 Mon Sep 17 00:00:00 2001 From: padreug Date: Tue, 23 Dec 2025 13:09:06 +0100 Subject: [PATCH] lamassu: clarify hostname option and add TODO for certificate redundancy MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The hostname is embedded in the pairing QR code and tells ATMs where to connect. Added a TODO to consider auto-populating certificate.extraIPs from hostname when it's an IP address. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- modules/lamassu-lnbits.nix | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/modules/lamassu-lnbits.nix b/modules/lamassu-lnbits.nix index dd2de20..82fbbd5 100644 --- a/modules/lamassu-lnbits.nix +++ b/modules/lamassu-lnbits.nix @@ -114,10 +114,16 @@ in hostname = mkOption { type = types.str; default = "localhost"; - description = "Hostname for the server (used by application)"; + description = '' + Hostname for the server. This is embedded in the pairing QR code + and tells ATMs where to connect. Can be an IP address or domain name. + ''; }; # Certificate options (same pattern as LND) + # TODO: When using an IP address, hostname and certificate.extraIPs are redundant. + # Consider auto-populating certificate.extraIPs from hostname if it's an IP, + # or unifying these options. For now, set both to the same IP address. certificate = { extraIPs = mkOption { type = with types; listOf str;