From c66a6aab3abcbd6e8da9e2302f997991b347abe6 Mon Sep 17 00:00:00 2001 From: Erik Arvstedt Date: Fri, 13 Dec 2024 23:21:25 +0100 Subject: [PATCH] python3Packages.joinmarket: allow Python 3.12 Python 3.12 is the default in Nixos 24.11. All tests succeed with Python 3.12. Context: Related issue: https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/1589 This issue contains no hints on what changes caused joinmarket to be incompatible/compatible with Python 3.12. The restriction to Python <3.12 was added here (https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1587) in Oct 2023. This post (https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/1589#issuecomment-2119278070) in the above issue mentions on 2024-05-19 that tests are running again with Python 3.12. The current joinmarket version (0.9.11) was released on 2024-02-22. --- pkgs/python-packages/joinmarket/default.nix | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkgs/python-packages/joinmarket/default.nix b/pkgs/python-packages/joinmarket/default.nix index 854f1e5..d524282 100644 --- a/pkgs/python-packages/joinmarket/default.nix +++ b/pkgs/python-packages/joinmarket/default.nix @@ -29,9 +29,8 @@ buildPythonPackage rec { inherit version src; format = "pyproject"; - # Since v0.9.11, Python older than v3.8 is not supported. Python v3.12 is - # still not supported. - disabled = (pythonOlder "3.8") || (pythonAtLeast "3.12"); + # Since v0.9.11, Python older than v3.8 is not supported. + disabled = pythonOlder "3.8"; nativeBuildInputs = [ setuptools