office pack ships signal-desktop → pulls insecure electron-39.8.10, build refuses #3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
modules/packs/office.nix:30addssignal-desktop, which depends onelectron-39.8.10. nixpkgs marks that electron as insecure (EOL), so evaluation fails:Enabling
packs.officetherefore breaks the build until the adopter manually addspermittedInsecurePackages.Impact
Medium — only hits adopters who enable the office pack, but it's a hard build failure with a non-obvious fix.
Suggested fix
Make the pack self-contained so it builds out of the box. Either:
(works because core configures nixpkgs via the module system —
lib/mksystem.nix:123), or bumpsignal-desktopto a version on a non-EOL electron.Note the security trade-off if permitting: EOL electron = no upstream security patches for Signal's runtime. Worth a comment in the pack documenting the choice.
Found while helping a friend adopt the template on existing NixOS.