aiolabs/payroll
9
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

fix: honour a stated rate whatever the calendar says

Browse source 
Pay-now on a period due next week offered "Rate on the payday" and then
found a rate anyway, with only a passive hint to explain why. Two separate
problems behind that.

The real one: `resolve_price` tested `payday >= today` before it tested the
mode, so `manual` was silently ignored for any period not already
back-dated. "Pay at the rate we agreed" quietly did not, and a contract
pegged to a fixed rate honoured it only on late periods. A stated rate is
an instruction rather than a lookup, so it now wins outright and applies to
every period. `payday` and `current` keep their old order — for a payday
today or ahead there is no history to consult, so `payday` collapses into
`current`, which is the only defensible answer for a date that has not
happened.

The cosmetic one: the dialog's hint said "ignored unless the payday is
already in the past", sitting beside a control that plainly appeared to do
something — and was about to become wrong anyway, since manual now always
applies. It is replaced by a line that names the actual period: either
"Payday 2026-09-05 has not passed, so there is no historical rate to look
up — this will be priced at the current rate", or "Will convert at what BTC
was worth on <date>". The dialog header now shows which payday is being
settled, which was not visible at all before.

The contract dialogs lose the same stale hint; their label becomes
"Pricing" rather than "Price a late payday at", which no longer describes
manual mode.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018jy52j9GRZ6XKa1Zt21LLj
This commit is contained in:
Padreug 2026-08-31 22:14:46 +02:00
commit 1584eb337f
5 changed files with 94 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

13
static/js/index.js
View file

@ -194,6 +194,19 @@ window.app = Vue.createApp({
)
},
// Which period pay-now would settle, and whether it is actually in the
// past. "Rate on the payday" cannot mean anything for a date that has
// not happened, and the dialog should say so rather than offer a choice
// that quietly does nothing.
payNowPayday() {
const c = this.payNowDialog.contract
return c ? c.next_payday : null
},
payNowIsBackdated() {
return !!this.payNowPayday && this.payNowPayday < today()
},
ledgerCsvHref() {
const f = this.ledgerFilter
const params = new URLSearchParams()