fix(v2)(security): wallet IDOR + settlement-processing concurrency

Closes the HIGH-severity security finding from the v2 branch review:
operator A could register a machine pointing at operator B's wallet_id
(or update their machine to do so), then drain B's wallet via the
settlement processor's pay_invoice call. LNbits' pay_invoice doesn't
enforce caller identity at the backend layer — wallet_id is trusted as
the source-of-truth for the source wallet.

Two-layer defence:

1. **API layer.** New _assert_wallet_owned_by helper in views_api.py
   refuses any wallet_id from the request body that doesn't resolve to a
   wallet owned by the authenticated operator. Applied on
   api_create_machine and api_update_machine. Pattern lifted from the
   existing api_settle_client_balance which already did this for
   funding_wallet_id (260-265 in the original file).

2. **DB layer.** m007 adds a UNIQUE index on dca_machines.wallet_id —
   even if a future endpoint forgets the API check, the DB rejects two
   rows claiming the same wallet. CREATE UNIQUE INDEX is portable across
   SQLite and PostgreSQL (ALTER TABLE ADD CONSTRAINT is not on SQLite).

Same commit also addresses concurrency findings H1+H2+H3 from the
architectural review (race conditions on process_settlement +
no retry path for errored settlements):

- m007 also adds processing_claim TEXT to dca_settlements.
- crud.claim_settlement_for_processing does optimistic-lock via
  UPDATE ... SET status='processing', processing_claim=:token
  WHERE id=:id AND status='pending'  (portable; no UPDATE...RETURNING).
  Read-back compares the token; only one concurrent caller wins.
- crud.reset_settlement_for_retry voids failed legs and flips
  'errored' → 'pending' so process_settlement re-runs them. Completed
  legs are LEFT IN PLACE — we never re-pay sats that already moved.
- crud.mark_settlement_status clears processing_claim on terminal
  states so a fresh claim attempt won't see a stale token.
- distribution.process_settlement now uses the claim instead of the
  status-read-and-check pattern. Concurrent listener re-fires +
  partial-dispense recomputes can't double-pay legs.
- New endpoint:
    POST /api/v1/dca/settlements/{id}/retry  (operator-scoped)
  Refuses if status != 'errored' (400). Resets, then re-runs
  process_settlement via the claim path.

DcaSettlement gains a processing_claim: Optional[str] field. Visible to
operators in settlement detail; stale claims (status='processing' for
many minutes) are a "processor crashed mid-flight" signal — operator
can manually mark errored + retry.

32 routes registered. 72/72 tests pass.

Refs: aiolabs/satmachineadmin#9 — closes the v2-branch security finding
and HIGH-priority concurrency findings from the internal review.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

migrations.py

@@ -446,3 +446,33 @@ async def m006_add_settlement_notes(db):
     await db.execute(
         "ALTER TABLE satoshimachine.dca_settlements ADD COLUMN notes TEXT"
     )
+
+
+async def m007_settlement_claim_and_machine_wallet_unique(db):
+    """Security + concurrency hardening (fix bundle 1).
+
+    1. Adds `processing_claim` to dca_settlements. The settlement processor
+       uses an optimistic-lock pattern: write a per-invocation claim token
+       alongside the status='processing' flip, then re-read and confirm the
+       persisted token matches. Two concurrent process_settlement invocations
+       on the same id can't both win the claim, so no duplicate leg
+       creation / double-pay.
+
+    2. Adds a UNIQUE index on dca_machines.wallet_id so two machine rows
+       can never claim the same wallet. Closes a wallet-IDOR funds-theft
+       vector where operator A could register a machine on operator B's
+       wallet_id and drain it via the settlement processor's pay_invoice.
+       Defence-in-depth on top of the API-layer ownership check; if a future
+       endpoint forgets the check, the DB still rejects.
+
+       CREATE UNIQUE INDEX is portable across SQLite and PostgreSQL
+       (ALTER TABLE ADD CONSTRAINT is not on SQLite).
+    """
+    await db.execute(
+        "ALTER TABLE satoshimachine.dca_settlements "
+        "ADD COLUMN processing_claim TEXT"
+    )
+    await db.execute(
+        "CREATE UNIQUE INDEX dca_machines_wallet_id_uq "
+        "ON satoshimachine.dca_machines (wallet_id)"
+    )