SQLite doesn't support Decimal natively - it stores DECIMAL columns as
REAL (float). This caused sqlite3.ProgrammingError when writing Decimal
values.
Changes:
- Add prepare_for_db() helper to convert Decimal→float before writes
- Add Pydantic validators to convert float→Decimal on model creation
- Update CRUD layer tests to verify float params for SQLite
- Add SQLite round-trip tests to verify precision is preserved
The data flow is now:
Decimal (calculations) → float (prepare_for_db) → SQLite → float → Decimal (validators)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tests verify the complete data flow:
- CSV parsing → Decimal conversion (simulates execute_ssh_query)
- Commission calculations with parsed Decimal values
- Distribution calculations with 2 and 4 client scenarios
- Pydantic model creation with Decimal types
- Exchange rate precision and round-trip accuracy
Uses real Lamassu transaction data (8.75%, 5.5% commission rates,
discounts, multiple client configurations).
37 tests now pass (23 unit + 14 integration).
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- calculations.py: Use Decimal for commission percentages, exchange rates,
and client balances. Added to_decimal() helper for safe float conversion.
Changed from banker's rounding to ROUND_HALF_UP.
- models.py: Changed all fiat amounts, percentages, and exchange rates to
Decimal. Added json_encoders for API serialization.
- transaction_processor.py: Convert to Decimal at data ingestion boundary
(CSV parsing). Updated all defaults and calculations to use Decimal.
- tests: Updated to work with Decimal return types.
This prevents floating-point precision issues in financial calculations.
All 23 tests pass.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Extract pure calculation functions to calculations.py (no lnbits deps)
- transaction_processor.py now imports from calculations.py (DRY)
- Add 22 tests covering commission, distribution, and fiat round-trip
- Include real Lamassu transaction data (8.75%, 5.5% commission rates)
- Test edge cases: discounts (90%, 100%), zero commission, small amounts
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
