aiolabs/webapp
9
0
Fork 0
Code Issues 70 Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request 'fix(wallet): gate the received-payment toast on status, not absent pending' (#169) from fix/wallet-payment-toast-guard into dev

Browse source 
Reviewed-on: #169
This commit is contained in:
padreug 2026-09-22 21:16:06 +00:00
commit 3e5eeaf7a9
1 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/modules/wallet/services/WalletWebSocketService.ts
View file

@ -289,14 +289,21 @@ export class WalletWebSocketService extends BaseService {
this.walletService.addTransaction(payment)
}
// Show toast notification for incoming payments
if (payment.amount > 0 && !payment.pending) {
// Toast incoming payments only, and only once settled.
//
// This guard used to read `!payment.pending`, which is never present in
// the payload (a pydantic `@property`; see mapPaymentStatus in
// WalletService), so it was always true and an unsettled payment could
// announce itself as received. `status` is the real field.
//
// The old `else` branch toasted outgoing payments but was unreachable,
// since the enclosing condition already required `amount > 0`. It is
// dropped rather than fixed: a send made from this app is already
// confirmed by SendDialog's own toast, so re-announcing it here would
// double up.
if (payment.amount > 0 && payment.status === 'success') {
const amountSats = Math.abs(payment.amount / 1000)
if (payment.amount > 0) {
this.toast.success(`Received ${amountSats} sats!`)
} else {
this.toast.info(`Sent ${amountSats} sats`)
}
this.toast.success(`Received ${amountSats} sats!`)
}
}