refactor(events): rename activities module to events + wire VITE_APP_NAME for per-deployment branding (#94)

## Why The module was named `activities` originally to avoid colliding with Nostr's `Event` type. In practice that defense added friction without preventing confusion — the backend extension is named `events`, NIP-52 calls them "Calendar Events", and the UI already displayed "Events". The collision with `nostr-tools` `Event` is handled cleanly by the existing `import { Event as NostrEvent }` alias pattern (already in 5 files inside the module). Renaming collapses the 4-way mismatch into one consistent term. Separately, deployments needed per-instance app names. `VITE_APP_NAME` was already plumbed per-standalone via NixOS `services.webapp-standalones.<app>.displayName` (e.g. cfaun shipped `"Sortir"`, now rebranded to `"Bouge"`), but nothing in the standalone consumed it — PWA manifest, HTML title, and runtime branding were all hardcoded. This PR wires the env through every app-name display point so any deploy can flip `displayName = "Bouge"` (or anything) and pick up the brand end-to-end. ## What Nine commits on the branch: 1. **`refactor(events): rename activities module to events`** — 70-file rename. `src/modules/activities/` → `src/modules/events/`, `src/activities-app/` → `src/events-app/`, types/services/composables/views/components/store renamed (`Activity`→`Event`, `Activities`→`Events`). Routes `/activities/*` → `/events/*`; the legacy `/events` (ticketing management) moves to `/my-events` so `/events` belongs to the canonical feed. DI tokens `ACTIVITIES_*` → `EVENTS_*`. i18n namespace renamed; English domain strings updated, French/Spanish title key realigned. npm scripts `:activities` → `:events`. Build output `dist-activities/` → `dist-events/`. 2. **`feat(events): wire VITE_APP_NAME through PWA manifest, HTML, runtime`** — PWA manifest `name`/`short_name` template from `process.env.VITE_APP_NAME` with fallback `'Events'`. `events.html` uses Vite's `%VITE_APP_NAME%` substitution. `src/events-app/app.ts` + `main.ts` runtime brand string drives console logs, offline notification, and `acceptTokenFromUrl()`. `events.title` route meta sources from VITE_APP_NAME. `.env.example` updated with per-standalone scoping notes. 3. **`docs(events): update activities→events references`** — `docs/nostr-patterns/*.md` "Canonical: src/modules/activities/composables/useRSVP.ts" anchors point at renamed paths. CLAUDE.md Payment Rails Pattern section updated. 4. **`fix(events): drop lowercase from PWA description brand name`** — minor casing fix caught during verification. 5. **`fix(events): use domain noun in description, not brand name`** — manifest + HTML description switched from `"Discover ${BRAND} near you"` to static `"Discover events near you"`. Description is about *what* the app does, not the brand. 6. **`chore(events): scrub leftover sortir/activities references`** — nginx.conf.example, package.json (concurrently process label + `build:demo` BASE_PATH), router-helpers comment, useMarket comment, and vite.events.config.ts doc-comment. 7. **`refactor(events): conditional brand in console label, tighten docs`** — adds `APP_LABEL` next to `APP_NAME` in `events-app/app.ts`. Reads as `Events` on unbranded builds and `Events (Bouge)` (etc.) when `VITE_APP_NAME` is set to anything other than "Events" (case-insensitive). Used by all four console messages; `acceptTokenFromUrl` keeps the raw `APP_NAME` (it's a token-namespace identifier, not display copy). Also collapses the redundant "cfaun sets X; future deployments can override (e.g. X)" doc-comment. 8. **`i18n(events): finish activité/actividad → événement/evento sweep`** — completes the i18n rename in fr.ts and es.ts (search placeholders, favorites prompts, settings prompt) and fixes five gender-agreement errors that came along with the masculine `événement`/`evento` switch (French: `Aucune ... trouvée`→`Aucun ... trouvé`, `préférées`→`préférés`, `d'une ... la sauvegarder`→`d'un ... le sauvegarder`; Spanish: `favoritas`→`favoritos`, `guardarla`→`guardarlo`). 9. **`chore(events): finish sortir → bouge sweep in .env.example`** — four remaining doc-comment refs in `.env.example` (cfaun branding, ticket-scanner comment, section header, subdomain-mode URL example). ## Cross-repo coordination This PR has matching changes already pushed to two other repos. They have to land in a coordinated bump because the names are tightly coupled. - **`aiolabs/webapp-module` main** — commit `9d82016`. Renames `hubActivitiesUrl` → `hubEventsUrl` and `VITE_HUB_ACTIVITIES_URL` → `VITE_HUB_EVENTS_URL`. No backwards-compat shim. - **`aiolabs/server-deploy` main** — commits `f15e1eb`, `bf4698b`, `d46a520`: - `standalones.nix` `apps.events` uses `build:events` / `dist-events` / `events.html`; `hubUrlOption` maps `events → "hubEventsUrl"`; comment + cfaun-as-example doc switched from sortir/Sortir to bouge/Bouge. - `hosts/cfaun/default.nix` rebranded: `subdomain = "bouge"` + `displayName = "Bouge"`. (Native-French feedback retired the "Sortir" branding as awkward.) - `hosts/atio/default.nix` stale "activities app" comment dropped (atio's `displayName = "Eventos"` config is unchanged). server-deploy's `flake.lock` still pins the OLD webapp + OLD webapp-module, so nix builds from server-deploy main will fail until the bumps. Suggested order after this PR merges to `dev`: one server-deploy commit that does `nix flake lock --update-input webapp-module` + `--update-input webapp-demo` together. DNS for `bouge.ariege.io` needs to point at the cfaun host before the deploy lands. ## Verification - `pnpm typecheck` — clean ✓ - `pnpm build:events` (default) — `dist-events/manifest.webmanifest` has `name: "Events"`, description "Discover events near you" ✓ - `VITE_APP_NAME=Bouge pnpm build:events` — `name: "Bouge"`, HTML title "Bouge", console label resolves to `Events (Bouge)` ✓ - Cross-repo grep sweep: no `Sortir`/`sortir`/`activities`/`Activities` references in events-module scope. (Domain false positives — "Market Activity" in market dashboard, "time-based activities" in nostr-feed content filters, "Activity Lifecycle Kills" in CLAUDE.md mobile-browser docs — are unrelated and intentionally left alone.) Not verified in-browser (no GUI in this session) — needs a manual smoke at `app.ariege.io/bouge/` once the coordinated flake bump lands on cfaun. Watch for: feed loads, `/events/calendar`, `/events/map`, `/events/favorites`, `/events/:id` routes work; "My Events" appears in the user dropdown and `/my-events` shows the management page; PWA install prompt shows "Bouge". ## Out of scope (deferred) - Backend extension rename — `aiolabs/events` is already named correctly. - Nix standalone attribute name — `services.webapp-standalones.events` is already correct. - Overriding domain-noun strings ("Your event was created", RSVP labels) — those stay locale-driven; `VITE_APP_NAME` covers app-name only. - Backwards-compat redirects from `/activities/*` to `/events/*` — pre-launch, public URL was `/sortir/` (path-mode) or `sortir.ariege.io` (subdomain-mode), never `/activities/`. No external bookmarks to preserve. (`sortir.ariege.io` → `bouge.ariege.io` is a separate decision; up to the deploy operator whether to keep a 301 for word-of-mouth referrers.) Reviewed-on: #94
2026-06-09 18:18:26 +00:00 · 2026-06-09 18:18:26 +00:00 · 5541d2bc7a
commit 5541d2bc7a
parent 1f20d5f00c
77 changed files with 849 additions and 1107 deletions
--- a/vite.events.config.ts
+++ b/vite.events.config.ts
@ -0,0 +1,138 @@
+import { fileURLToPath, URL } from 'node:url'
+import vue from '@vitejs/plugin-vue'
+import tailwindcss from '@tailwindcss/vite'
+import { defineConfig, type Plugin } from 'vite'
+import { VitePWA } from 'vite-plugin-pwa'
+import { ViteImageOptimizer } from 'vite-plugin-image-optimizer'
+import { visualizer } from 'rollup-plugin-visualizer'
+
+/**
+ * Plugin to rewrite dev server requests to events.html
+ * (SPA fallback for the standalone events app entry point)
+ */
+function eventsHtmlPlugin(): Plugin {
+  return {
+    name: 'events-html-rewrite',
+    configureServer(server) {
+      server.middlewares.use((req, _res, next) => {
+        // Rewrite all non-asset requests to events.html.
+        // Strip query before checking for an extension — JWTs (e.g. ?token=...)
+        // contain dots and would otherwise get mistaken for an asset request.
+        const path = req.url ? req.url.split('?')[0] : ''
+        if (
+          req.url &&
+          !req.url.startsWith('/@') &&
+          !req.url.startsWith('/src/') &&
+          !req.url.startsWith('/node_modules/') &&
+          !path.includes('.')
+        ) {
+          req.url = '/events.html'
+        }
+        next()
+      })
+    },
+  }
+}
+
+/**
+ * Vite config for the standalone events app.
+ *
+ * Set VITE_BASE_PATH to deploy under a path prefix:
+ *   VITE_BASE_PATH=/events/ → app.ariege.io/events/ (shared auth)
+ *   (default: /)            → bouge.ariege.io (standalone subdomain)
+ *
+ * Set VITE_APP_NAME to brand the standalone (PWA name, HTML title, console
+ * logs). cfaun overrides to "Bouge" via NixOS. Defaults to "Events".
+ */
+const APP_NAME = process.env.VITE_APP_NAME || 'Events'
+// Surface the resolved value back into env so Vite's HTML %VITE_APP_NAME%
+// substitution picks up the fallback when nothing was explicitly set.
+process.env.VITE_APP_NAME = APP_NAME
+
+export default defineConfig(({ mode }) => ({
+  base: process.env.VITE_BASE_PATH || '/',
+  // Per-app dep cache so concurrent dev servers don't race on .vite/deps
+  cacheDir: 'node_modules/.vite-events',
+  server: {
+    port: 5181,
+    strictPort: true,
+  },
+  plugins: [
+    eventsHtmlPlugin(),
+    vue(),
+    tailwindcss(),
+    VitePWA({
+      registerType: 'autoUpdate',
+      devOptions: {
+        enabled: false,
+      },
+      workbox: {
+        globPatterns: ['**/*.{js,css,html,ico,png,svg}'],
+        // Scope the service worker to only handle requests within this app's path
+        navigateFallback: 'events.html',
+        navigateFallbackAllowlist: [
+          new RegExp(`^${(process.env.VITE_BASE_PATH || '/').replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}`),
+        ],
+      },
+      includeAssets: [
+        'favicon.ico',
+        'apple-touch-icon.png',
+        'mask-icon.svg',
+        'icon-192.png',
+        'icon-512.png',
+        'icon-maskable-192.png',
+        'icon-maskable-512.png',
+      ],
+      manifest: {
+        name: APP_NAME,
+        short_name: APP_NAME,
+        description: 'Discover events near you',
+        theme_color: '#1f2937',
+        background_color: '#ffffff',
+        display: 'standalone',
+        orientation: 'portrait-primary',
+        start_url: process.env.VITE_BASE_PATH || '/',
+        scope: process.env.VITE_BASE_PATH || '/',
+        id: 'aiolabs-events',
+        categories: ['social', 'entertainment', 'lifestyle'],
+        icons: [
+          { src: 'icon-192.png', sizes: '192x192', type: 'image/png', purpose: 'any' },
+          { src: 'icon-512.png', sizes: '512x512', type: 'image/png', purpose: 'any' },
+          { src: 'icon-maskable-192.png', sizes: '192x192', type: 'image/png', purpose: 'maskable' },
+          { src: 'icon-maskable-512.png', sizes: '512x512', type: 'image/png', purpose: 'maskable' },
+        ],
+      },
+    }),
+    ViteImageOptimizer({
+      jpg: { quality: 80 },
+      png: { quality: 80 },
+      webp: { lossless: true },
+    }),
+    mode === 'analyze' &&
+      visualizer({
+        open: true,
+        filename: 'dist-events/stats.html',
+        gzipSize: true,
+        brotliSize: true,
+      }),
+  ],
+  resolve: {
+    alias: {
+      '@': fileURLToPath(new URL('./src', import.meta.url)),
+    },
+  },
+  build: {
+    outDir: 'dist-events',
+    rollupOptions: {
+      input: 'events.html',
+      output: {
+        manualChunks: {
+          'vue-vendor': ['vue', 'vue-router', 'pinia'],
+          'ui-vendor': ['radix-vue', '@vueuse/core'],
+          'shadcn': ['class-variance-authority', 'clsx', 'tailwind-merge'],
+        },
+      },
+    },
+    chunkSizeWarningLimit: 1000,
+  },
+}))