Compare commits

..

No commits in common. "3e5eeaf7a9a997669e6b43e1a1f7e20814494fea" and "8438e9f26dd4133d3dce907a13e0bc8b4e58ac74" have entirely different histories.

View file

@ -289,21 +289,14 @@ export class WalletWebSocketService extends BaseService {
this.walletService.addTransaction(payment) this.walletService.addTransaction(payment)
} }
// Toast incoming payments only, and only once settled. // Show toast notification for incoming payments
// if (payment.amount > 0 && !payment.pending) {
// This guard used to read `!payment.pending`, which is never present in
// the payload (a pydantic `@property`; see mapPaymentStatus in
// WalletService), so it was always true and an unsettled payment could
// announce itself as received. `status` is the real field.
//
// The old `else` branch toasted outgoing payments but was unreachable,
// since the enclosing condition already required `amount > 0`. It is
// dropped rather than fixed: a send made from this app is already
// confirmed by SendDialog's own toast, so re-announcing it here would
// double up.
if (payment.amount > 0 && payment.status === 'success') {
const amountSats = Math.abs(payment.amount / 1000) const amountSats = Math.abs(payment.amount / 1000)
this.toast.success(`Received ${amountSats} sats!`) if (payment.amount > 0) {
this.toast.success(`Received ${amountSats} sats!`)
} else {
this.toast.info(`Sent ${amountSats} sats`)
}
} }
} }