Show fiat amounts in wallet transaction history #167
Labels
No labels
app:activities
app:chat
app:chatelet
app:events
app:forum
app:libra
app:market
app:restaurant
app:tasks
app:wallet
app:webapp
bug
enhancement
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
aiolabs/webapp#167
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up to #166, which lets an invoice be denominated in fiat. The history list still shows sats only, so a €5.50 invoice appears as "7,301 sats" and the quote the payer actually agreed to is lost.
LNbits already stores what is needed on every payment's
extra:That is present for any payment created with a fiat
unit, and also for outgoing LNURL payments sent with one.Work
fiatAmount/fiatCurrencythroughmapPaymentToTransactionontoPaymentTransaction.formatCurrencyfromuseCurrencieshandles locale and symbol.Why it was not in #166
It applies to all payments rather than only newly created ones, and it edits the shared payment mapper that #161 rewrites. Keeping it separate avoided a conflict between the two.
Worth considering at the same time: an optional "show amounts in my preferred currency" display setting, converting sat-denominated rows at the current rate. That is a different feature from recording the denomination a payment was actually quoted in, and should not be conflated with it.