Remove redundant per-app SettingsPage.vue views #50

New issue

Open

opened 2026-05-07 09:52:39 +00:00 by padreug · 0 comments

padreug commented

2026-05-07 09:52:39 +00:00

Owner

After the unified bottom-nav refactor lands, theme / language / currency preferences move into the shared profile sheet (<ProfileSheetContent>). Several apps currently have a dedicated SettingsPage.vue route mostly devoted to those same controls:

src/modules/activities/views/SettingsPage.vue (also surfaced as a Settings tab in the bottom nav)
src/modules/accounting/views/SettingsPage.vue (Libra)
Possibly others — audit during this ticket.

Scope

Audit each SettingsPage.vue in the src/modules/ tree.
If the page only contains theme/lang/currency UI: delete the page + route + nav entry, run a follow-up codemod for any router.push('/settings') callsites.
If the page has app-specific settings (notification prefs, default views, etc.): keep the page, slim it down to remove the global-pref controls, possibly rename to a more specific name (e.g. NotificationsSettings.vue).

Why now

Filed as a follow-up to the unified bottom-nav plan; not bundling into the initial refactor PR because deletions deserve focused review.

Depends on

The unified app shell + profile sheet being merged.

Acceptance

Each remaining SettingsPage.vue only contains app-specific settings.
Bottom-nav Settings tabs (where they only led to the global-prefs page) are removed.
Routes deleted for empty pages; no dangling router.push references.

After the unified bottom-nav refactor lands, theme / language / currency preferences move into the shared profile sheet (`<ProfileSheetContent>`). Several apps currently have a dedicated `SettingsPage.vue` route mostly devoted to those same controls: - `src/modules/activities/views/SettingsPage.vue` (also surfaced as a Settings tab in the bottom nav) - `src/modules/accounting/views/SettingsPage.vue` (Libra) - Possibly others — audit during this ticket. ## Scope - Audit each `SettingsPage.vue` in the `src/modules/` tree. - If the page only contains theme/lang/currency UI: delete the page + route + nav entry, run a follow-up codemod for any `router.push('/settings')` callsites. - If the page has *app-specific* settings (notification prefs, default views, etc.): keep the page, slim it down to remove the global-pref controls, possibly rename to a more specific name (e.g. `NotificationsSettings.vue`). ## Why now Filed as a follow-up to the unified bottom-nav plan; not bundling into the initial refactor PR because deletions deserve focused review. ## Depends on - The unified app shell + profile sheet being merged. ## Acceptance - [ ] Each remaining `SettingsPage.vue` only contains app-specific settings. - [ ] Bottom-nav `Settings` tabs (where they only led to the global-prefs page) are removed. - [ ] Routes deleted for empty pages; no dangling `router.push` references.

padreug referenced this issue

2026-05-07 10:06:37 +00:00

feat(layout): unified app-shell primitives (Phase A) #51

padreug referenced this issue from a commit

2026-05-07 10:26:30 +00:00

feat(layout): adopt unified AppShell across hub + 7 standalones (Phase B)

padreug referenced this issue

2026-05-07 10:27:10 +00:00

feat(layout): adopt unified AppShell across hub + 7 standalones (Phase B) #52

padreug added the

app:webapp

enhancement