chore(base): delete nostr-metadata-service + retire webapp-side kind-0 broadcast paths #82
1 changed files with 25 additions and 4 deletions
fix(api): align webapp client with post-cascade lnbits + surface error detail
Two fixes that together make the kind-0 server-side publish path (this PR's whole reason for existing) actually work end-to-end against the deployed cascade: 1. **updateProfile() uses PATCH /api/v1/auth, not PUT /auth/update.** aiolabs/lnbits PR #26 gap-fill (869f67c3) wired _publish_nostr_metadata_event into the PATCH handler at auth_api.py:546. The legacy `/auth/update` route doesn't exist on the post-cascade server — a `PUT /auth/update` request gets routed into the `/auth/{provider}` SSO wildcard which only allows GET and returns 405. Caught while smoke-testing this PR against a local regtest pointed at the issue-18-phase-2.3 branch. 2. **request<T>() parses FastAPI's `{"detail": "..."}` error shape.** The old error path threw `API request failed: 405 Method Not Allowed` for the regtest's 405 above — useful only if you also opened the network panel and read the response body manually. Now we parse the detail (string or pydantic-validation array), include the endpoint path, and throw `LNbits /auth 405: Method Not Allowed`. Falls back to raw text for non-JSON bodies. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
commit
261eded316
|
|
@ -112,12 +112,29 @@ export class LnbitsAPI extends BaseService {
|
||||||
|
|
||||||
if (!response.ok) {
|
if (!response.ok) {
|
||||||
const errorText = await response.text()
|
const errorText = await response.text()
|
||||||
|
// Try to surface FastAPI's `{"detail": "..."}` shape; fall back to raw
|
||||||
|
// body for non-JSON errors. Without this, every backend error renders
|
||||||
|
// as a generic "API request failed: <status>" and you can't distinguish
|
||||||
|
// "wrong endpoint" from "expired token" from "validation failure".
|
||||||
|
let detail: string = errorText
|
||||||
|
try {
|
||||||
|
const parsed = JSON.parse(errorText)
|
||||||
|
if (parsed && typeof parsed.detail === 'string') {
|
||||||
|
detail = parsed.detail
|
||||||
|
} else if (parsed && Array.isArray(parsed.detail)) {
|
||||||
|
// pydantic ValidationError: take the first msg
|
||||||
|
detail = parsed.detail[0]?.msg ?? errorText
|
||||||
|
}
|
||||||
|
} catch {
|
||||||
|
// body wasn't JSON; keep the raw text in `detail`
|
||||||
|
}
|
||||||
console.error('LNBits API Error:', {
|
console.error('LNBits API Error:', {
|
||||||
|
endpoint,
|
||||||
status: response.status,
|
status: response.status,
|
||||||
statusText: response.statusText,
|
statusText: response.statusText,
|
||||||
errorText
|
detail,
|
||||||
})
|
})
|
||||||
throw new Error(`API request failed: ${response.status} ${response.statusText}`)
|
throw new Error(`LNbits ${endpoint} ${response.status}: ${detail || response.statusText}`)
|
||||||
}
|
}
|
||||||
|
|
||||||
const data = await response.json()
|
const data = await response.json()
|
||||||
|
|
@ -186,8 +203,12 @@ export class LnbitsAPI extends BaseService {
|
||||||
}
|
}
|
||||||
|
|
||||||
async updateProfile(data: Partial<User>): Promise<User> {
|
async updateProfile(data: Partial<User>): Promise<User> {
|
||||||
return this.request<User>('/auth/update', {
|
// aiolabs/lnbits PR #26 (gap-fill 869f67c3) wired
|
||||||
method: 'PUT',
|
// _publish_nostr_metadata_event into PATCH /api/v1/auth
|
||||||
|
// (auth_api.py:546). The legacy PUT /auth/update route does not
|
||||||
|
// exist on the post-cascade server.
|
||||||
|
return this.request<User>('/auth', {
|
||||||
|
method: 'PATCH',
|
||||||
body: JSON.stringify(data),
|
body: JSON.stringify(data),
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue