aiolabs/withdraw
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: multiple withdraws not possible when locked (#30)
Some checks failed
/ release (push) Has been cancelled
Details
/ pullrequest (push) Has been cancelled
Details

Browse source 
* fix: multiple withdraws not possible when locked
closes #29
This commit is contained in:
dni ⚡ 2024-04-19 13:08:35 +02:00 • committed by GitHub
commit f350e4cbf0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

38
lnurl.py
View file

@ -83,16 +83,6 @@ async def api_lnurl_callback(
pr: str = Query(...), pr: str = Query(...),
id_unique_hash=None, id_unique_hash=None,
): ):
# Create a record with the id_unique_hash or unique_hash, if it already exists, raise an exception thus preventing the same LNURL from being processed twice.
try:
if id_unique_hash:
await create_hash_check(id_unique_hash, k1)
else:
await create_hash_check(unique_hash, k1)
except Exception as e:
raise HTTPException(
status_code=HTTPStatus.BAD_REQUEST, detail="LNURL already being processed."
)
link = await get_withdraw_link_by_hash(unique_hash) link = await get_withdraw_link_by_hash(unique_hash)
if not link: if not link:
@ -116,6 +106,7 @@ async def api_lnurl_callback(
detail=f"wait link open_time {link.open_time - now} seconds.", detail=f"wait link open_time {link.open_time - now} seconds.",
) )
if id_unique_hash: if id_unique_hash:
if check_unique_link(link, id_unique_hash): if check_unique_link(link, id_unique_hash):
await remove_unique_withdraw_link(link, id_unique_hash) await remove_unique_withdraw_link(link, id_unique_hash)
@ -124,6 +115,15 @@ async def api_lnurl_callback(
status_code=HTTPStatus.NOT_FOUND, detail="withdraw not found." status_code=HTTPStatus.NOT_FOUND, detail="withdraw not found."
) )
# Create a record with the id_unique_hash or unique_hash, if it already exists,
# raise an exception thus preventing the same LNURL from being processed twice.
try:
await create_hash_check(id_unique_hash or unique_hash, k1)
except Exception as exc:
raise HTTPException(
status_code=HTTPStatus.BAD_REQUEST, detail="LNURL already being processed."
) from exc
try: try:
payment_hash = await pay_invoice( payment_hash = await pay_invoice(
wallet_id=link.wallet, wallet_id=link.wallet,
@ -132,21 +132,19 @@ async def api_lnurl_callback(
extra={"tag": "withdraw", "withdrawal_link_id": link.id}, extra={"tag": "withdraw", "withdrawal_link_id": link.id},
) )
await increment_withdraw_link(link) await increment_withdraw_link(link)
# If the payment succeeds, delete the record with the unique_hash. If it has unique_hash, do not delete to prevent the same LNURL from being processed twice. # If the payment succeeds, delete the record with the unique_hash.
if not id_unique_hash: # If it has unique_hash, do not delete to prevent the same LNURL from being processed twice.
await delete_hash_check(unique_hash) await delete_hash_check(id_unique_hash or unique_hash)
if link.webhook_url: if link.webhook_url:
await dispatch_webhook(link, payment_hash, pr) await dispatch_webhook(link, payment_hash, pr)
return {"status": "OK"} return {"status": "OK"}
except Exception as e: except Exception as exc:
# If payment fails, delete the hash stored so another attempt can be made. # If payment fails, delete the hash stored so another attempt can be made.
if id_unique_hash: await delete_hash_check(id_unique_hash or unique_hash)
await delete_hash_check(id_unique_hash)
else:
await delete_hash_check(unique_hash)
raise HTTPException( raise HTTPException(
status_code=HTTPStatus.BAD_REQUEST, detail=f"withdraw not working. {str(e)}" status_code=HTTPStatus.BAD_REQUEST, detail=f"withdraw not working. {str(exc)}"
) ) from exc
def check_unique_link(link: WithdrawLink, unique_hash: str) -> bool: def check_unique_link(link: WithdrawLink, unique_hash: str) -> bool: