avi/Keynctr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

checkpoint: document layout pass and re-critique (27→30/40)

Browse source
This commit is contained in:
Avi 2026-09-01 11:21:05 -05:00
commit 8461dd3a5d
1 changed files with 32 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

47
CHECKPOINT-encryption.md
View file

@ -1,11 +1,10 @@
# Checkpoint — HomeScreen keyboard accessibility (2026-09-01) # Checkpoint — HomeScreen layout + re-critique (2026-09-01)
## Where things are ## Where things are
- Project: `/home/avi/Projects/Keynctr` - Project: `/home/avi/Projects/Keynctr`
- Git repo: `master` @ `f1236e7` ("checkpoint: document clippy warning cleanup"). - Git repo: `master` @ `32fc764` ("fix(polish): restore success-soft background on identity card").
- Working tree: **3 modified files uncommitted** (the harden changes below) plus - Working tree: clean except the usual untracked items (`.directory`, `.opencode/`,
the usual untracked items (`.directory`, `.opencode/`, `.impeccable/`, `.impeccable/`, `COSMIC_THEME.md`, `KeynectrAppIconPossibility02.jpeg`).
`COSMIC_THEME.md`, `KeynectrAppIconPossibility02.jpeg`).
## What was completed ## What was completed
1. **Clippy is now warning-free.** Removed the two pre-existing warnings: the 1. **Clippy is now warning-free.** Removed the two pre-existing warnings: the
@ -39,19 +38,38 @@
- Added descriptive `aria-label` including profile name and active state. - Added descriptive `aria-label` including profile name and active state.
- Added `.home-profile-row:not(.is-active):focus-visible` CSS rule for the - Added `.home-profile-row:not(.is-active):focus-visible` CSS rule for the
standard 2px solid var(--focus) + 2px offset ring. standard 2px solid var(--focus) + 2px offset ring.
- Updated the test from `findByRole('list')` to `findByRole('listbox')`. - Updated the test from `findByRole('list')` to `findByRole('listbox')`.
7. **HomeScreen design-system alignment (this session).** Polish pass addressing
critique findings:
- Removed the identity card's `linear-gradient` background — now flat
`var(--surface)` with `border-color: var(--success)` (flat-by-default rule).
- Fixed `.home-profile-row` border-radius from `8px` to `var(--radius-sm)` (9px).
- Replaced the publication empty-state sentence with a centered layout: icon +
muted text + secondary button, matching the product's empty-state language.
- Normalized `.home-identity-name` font-size from `18px` to `16px` (consistent
with `.profile-name`).
- Removed redundant `grid-template-columns: 1fr` from `.home-grid`.
8. **First-run guide redesign (this session).** Replaced plain `<ol>` with visual
step indicators: each step has a `primary-soft` icon circle (users, copy, edit)
alongside a title + description. Clear spatial hierarchy, consistent 14px text.
9. **Identity card background restored.** After removing the gradient, the card
lost its green tint. Restored as flat `var(--success-soft)` background — keeps
the security-state signal without breaking flat-by-default.
10. **Re-critique score: 27/40 → 30/40 (Good).** All P1s resolved, all P2s
resolved. Remaining items are P3 (keyboard shortcuts, search/filter, minor
copy inconsistencies).
## Commits added in this session (newest first) ## Commits added in this session (newest first)
- `32fc764` fix(polish): restore success-soft background on identity card
- `b05894e` fix(layout): redesign first-run guide with visual step indicators
- `96dcbe4` fix(polish): align HomeScreen with design system
- `e9022b3` fix(a11y): add keyboard accessibility to HomeScreen profile list
- `a47ce8b` checkpoint: document keyboard accessibility hardening
- `f1236e7` checkpoint: document clippy warning cleanup - `f1236e7` checkpoint: document clippy warning cleanup
- `3083a44` chore: fix two clippy warnings - `3083a44` chore: fix two clippy warnings
- `0207636` feat: expose profile import over IPC - `0207636` feat: expose profile import over IPC
- `2604cf9` checkpoint: document release packages - `2604cf9` checkpoint: document release packages
**Uncommitted (this session):**
- `frontend/src/screens/HomeScreen.tsx` — keyboard accessibility for profile list
- `frontend/src/styles.css` — focus-visible styling for profile rows
- `frontend/src/test/HomeScreen.test.tsx` — updated test role to listbox
## Verification commands run ## Verification commands run
All green in this session, run after the changes: All green in this session, run after the changes:
@ -95,7 +113,6 @@ All green in this session, run after the changes:
not committed. not committed.
- README is stale (title, dependency versions, test counts, Forgejo references) — - README is stale (title, dependency versions, test counts, Forgejo references) —
worth a docs pass before 0.2. worth a docs pass before 0.2.
- **HomeScreen critique follow-up** (from `/impeccable critique`): 27/40 score. - **HomeScreen critique**: 30/40 (Good). Remaining P3 items: keyboard shortcuts,
Remaining P1: identity card gradient breaks flat-by-default rule. P2: flat profile search/filter, "Compose note" vs "Compose" label inconsistency,
first-run guide, off-system 8px border-radius, publication empty state as identity card kicker text removed. See `.impeccable/critique/` for snapshots.
sentence. See `.impeccable/critique/2026-09-01T15-55-28Z__...` for full report.