avi/S.H.O.N.A.R._Desktop_Companion
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Summarize always shows a percentage: the pre-token wait state read 'Summarizing… waiting for model' with no number; now 'Summarizing… 0% waiting for model' everywhere it appears (jobProgress, both detail labels, reprocess initial busy). Tests updated.

Browse source
This commit is contained in:
avi 2026-09-17 14:26:16 -05:00
commit 8586bc2476
3 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/src/main/kotlin/com/shonar/desktop/DesktopState.kt
View file

@ -1514,7 +1514,8 @@ class DesktopState(private val appDir: File = defaultAppDir()) {
pollJob = scope.launch { pollJob = scope.launch {
synchronized(runningGate) { runningSet += d0.file.name } synchronized(runningGate) { runningSet += d0.file.name }
try { try {
d0.busy = if (job == "transcribe") "Re-transcribing…" else "Summarizing…" d0.busy = if (job == "transcribe") "Re-transcribing…"
else "Summarizing… 0%"
d0.uploadProgress = null d0.uploadProgress = null
d0.error = null d0.error = null
_detail.value = d0.copy() _detail.value = d0.copy()
@ -1669,9 +1670,10 @@ class DesktopState(private val appDir: File = defaultAppDir()) {
if (s.progress != null) if (s.progress != null)
LiveProgress("summarizing… ${s.progress}%", s.progress / 100f) LiveProgress("summarizing… ${s.progress}%", s.progress / 100f)
// No tokens yet: the LLM is cold or the server is busy // No tokens yet: the LLM is cold or the server is busy
// queueing. Saying so (and for how long) beats a bar // queueing. Still show a number (0%) — a summarize must
// that looks frozen. // always display a percentage (user request) — plus the
else LiveProgress("summarizing… waiting for model" + // reason and wait time so 0% doesn't look frozen.
else LiveProgress("summarizing… 0% waiting for model" +
waitSuffix(s.startedAt, nowMs), null) waitSuffix(s.startedAt, nowMs), null)
else -> null else -> null
} }

4
app/src/main/kotlin/com/shonar/desktop/Screens.kt
View file

@ -779,7 +779,7 @@ fun DetailScreen(state: DesktopState) {
val label = when { val label = when {
it.status == "running" && it.progress != null -> it.status == "running" && it.progress != null ->
"Summarizing… ${it.progress}%" "Summarizing… ${it.progress}%"
it.status == "running" -> "Summarizing… waiting for model" + it.status == "running" -> "Summarizing… 0% waiting for model" +
DesktopState.waitSuffix(it.startedAt, System.currentTimeMillis()) DesktopState.waitSuffix(it.startedAt, System.currentTimeMillis())
else -> "Summary queued" + else -> "Summary queued" +
DesktopState.waitSuffix(it.createdAt, System.currentTimeMillis()) DesktopState.waitSuffix(it.createdAt, System.currentTimeMillis())
@ -976,7 +976,7 @@ fun DetailScreen(state: DesktopState) {
DesktopState.waitSuffix(sJob?.createdAt, DesktopState.waitSuffix(sJob?.createdAt,
System.currentTimeMillis()) System.currentTimeMillis())
sProg != null && sProg > 0 -> "Summarizing… $sProg%" sProg != null && sProg > 0 -> "Summarizing… $sProg%"
else -> "Summarizing… waiting for model" + else -> "Summarizing… 0% waiting for model" +
DesktopState.waitSuffix(sJob?.startedAt, DesktopState.waitSuffix(sJob?.startedAt,
System.currentTimeMillis()) System.currentTimeMillis())
}) })

4
app/src/test/kotlin/com/shonar/desktop/JobProgressTest.kt
View file

@ -45,7 +45,7 @@ class JobProgressTest {
val p = DesktopState.jobProgress( val p = DesktopState.jobProgress(
listOf(job("transcribe", "succeeded"), job("summarize", "running")), listOf(job("transcribe", "succeeded"), job("summarize", "running")),
) )
assertEquals("summarizing… waiting for model", p?.label) assertEquals("summarizing… 0% waiting for model", p?.label)
assertNull(p?.fraction) assertNull(p?.fraction)
} }
@ -67,7 +67,7 @@ class JobProgressTest {
.withNano(0).toString() .withNano(0).toString()
val p = DesktopState.jobProgress( val p = DesktopState.jobProgress(
listOf(job("summarize", "running", startedIso = iso)), nowMs = t0) listOf(job("summarize", "running", startedIso = iso)), nowMs = t0)
assertEquals("summarizing… waiting for model · 1:23", p?.label) assertEquals("summarizing… 0% waiting for model · 1:23", p?.label)
} }
@Test fun `waitSuffix formats and ignores unknowns`() { @Test fun `waitSuffix formats and ignores unknowns`() {