events/docs/upstream-candidates.md
Padreug 3a8e0ff591
Some checks failed
lint.yml / fix: Date/Message-ID/From-name on ticket emails, richer body (1.6.1-aio.9) (pull_request) Failing after 0s
lint.yml / fix: Date/Message-ID/From-name on ticket emails, richer body (1.6.1-aio.9) (push) Failing after 0s
fix: Date/Message-ID/From-name on ticket emails, richer body (1.6.1-aio.9)
A tester's ticket email landed in spam. A mail-tester run against demo
scored 8.3/10 with SPF, DKIM and DMARC all passing through the VPS relay,
so the deductions were all in the message: MISSING_DATE (1.4),
HTML_IMAGE_ONLY_04 (0.3), MISSING_MID (0.1) — and Gmail/Outlook weigh a
missing Date/Message-ID as "machine-generated" far more than that.

- `build_ticket_email` sets Date, a Message-ID under the sender domain,
  and a From display name from `lnbits_site_title`.
- The body now carries the event name, dates, location, name on ticket,
  ticket id and the door instruction, so the HTML part is no longer a
  QR with a handful of words.

Upstream candidate: lnbits core `send_email` has the same omissions.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EYwoAkZZmXMMmaBp4WGUBo
2026-09-08 16:19:38 +02:00

4.6 KiB

Upstream PR candidates

Running log of fork features that are shaped so they could be offered to lnbits/events (or lnbits/lnbits). Add a row whenever a change lands here in an upstream-compatible form; strike it when the PR merges upstream.

Feature Where Upstream target Readiness
frontend_url + origin allow-list + ?checkout= return contract views_api.py _resolve_frontend_root, api_ticket_create lnbits/events after the #33 rebase, as a small PR
Ticket ids minted before the invoice so success_url can carry them api_ticket_create lnbits/events ships with the above
extra.checkout (success/cancel URL, customer_email, line item, metadata) on fiat purchases api_ticket_create lnbits/events (needs lnbits StripeCheckoutOptions.cancel_url/customer_email, PR'd from aiolabs/lnbits) with the lnbits patch
extra.payment_methods per event + tickets_payment_methods NIP-52 tag models.py, nostr_publisher.py lnbits/events (v2 PR #64 introduces the same field) offer as review input on #64
asyncio.to_thread around the smtplib send services.py _send_ticket_email_notification lnbits/events trivial, standalone
QR logo overlay in make_qr_png (instance lnbits_qr_logo) views_api.py lnbits/events standalone
Multi-ticket purchase as N rows on one payment_hash api_ticket_create, crud.py lnbits/events overlaps v2 baskets; review input on #64
Free tickets without minting an invoice _issue_free_tickets lnbits/events small, standalone
NIP-52 publishing + approval workflow nostr_*.py, views_api.py lnbits/events #46 open; rebase onto v1.6.8
Date + Message-ID + From display name on the ticket email (build_ticket_email); event details in the body services.py lnbits/events (mailer) and lnbits/lnbits send_email (same omissions, hits password-reset/admin mails) trivial, standalone — measured: SpamAssassin MISSING_DATE 1.4 + MISSING_MID 0.14