Show voided transactions in user-entries endpoint #34

Merged

padreug merged 2 commits from feat/show-voided-user-entries into main

2026-06-07 13:38:30 +00:00

padreug commented

2026-06-06 18:48:46 +00:00

Owner

Summary

/api/v1/entries/user no longer silently drops transactions tagged voided, so users can see their rejected entries instead of having them disappear from history.
Admin dashboard transactions table detects voided rows via the voided tag (the reject convention keeps flag=!), giving the grey "Voided" icon precedence over the flag-based branch. Without this, voided rows would render as orange "Pending" once the backend stops filtering them.

Context

Per libra reject semantics, rejected entries keep the ! flag and append a voided tag inline for audit. The pending-approvals endpoint still filters voided — only the user-facing journal listing changes.

Webapp companion

aiolabs/webapp PR feat/libra-show-voided ships the standalone UI changes (inline strike-through styling + Pending-section exclusion). Merge order doesn't matter, but the UX only feels right with both in place.

Test plan

Restart regtest LNbits and confirm /libra/api/v1/entries/user now returns voided entries for a regular user (e.g. Nancy)
Open the admin dashboard transactions table and verify voided rows render with the grey cancel icon, not orange Pending
Confirm pending-approvals view still excludes voided entries

## Summary - `/api/v1/entries/user` no longer silently drops transactions tagged `voided`, so users can see their rejected entries instead of having them disappear from history. - Admin dashboard transactions table detects voided rows via the `voided` tag (the reject convention keeps flag=`!`), giving the grey "Voided" icon precedence over the flag-based branch. Without this, voided rows would render as orange "Pending" once the backend stops filtering them. ## Context Per libra reject semantics, rejected entries keep the `!` flag and append a `voided` tag inline for audit. The pending-approvals endpoint still filters voided — only the user-facing journal listing changes. ## Webapp companion `aiolabs/webapp` PR `feat/libra-show-voided` ships the standalone UI changes (inline strike-through styling + Pending-section exclusion). Merge order doesn't matter, but the UX only feels right with both in place. ## Test plan - [ ] Restart regtest LNbits and confirm `/libra/api/v1/entries/user` now returns voided entries for a regular user (e.g. Nancy) - [ ] Open the admin dashboard transactions table and verify voided rows render with the grey cancel icon, not orange Pending - [ ] Confirm pending-approvals view still excludes voided entries

padreug added 2 commits

2026-06-06 18:48:46 +00:00

feat(api): include voided transactions in user-entries endpoint 1c89e69030

The /api/v1/entries/user view was silently dropping any transaction tagged
'voided', so users couldn't see entries that had been rejected against
their accounts. Per the libra reject convention, voided entries keep the
'!' flag and carry a 'voided' tag for audit; clients can use the tag to
style them distinctly. Pending-approval listing still filters voided.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

fix(dashboard): detect voided rows by tag, not by flag char 781059af5f

The admin transactions table assumed voided entries used flag='x', but
the libra reject convention keeps the '!' flag and appends a 'voided'
tag. Without this, the dashboard rendered voided rows as orange 'Pending'
once they started reaching it. Detect via tag and give the voided icon
precedence over the flag-based branch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

padreug merged commit 9c88993c13 into main

2026-06-07 13:38:30 +00:00

padreug deleted branch feat/show-voided-user-entries

2026-06-07 13:38:31 +00:00

padreug referenced this pull request from a commit

2026-06-07 13:38:31 +00:00

Merge pull request 'Show voided transactions in user-entries endpoint' (#34) from feat/show-voided-user-entries into main