chore(tests): remove stale `test_init.py` cookiecutter leftover #35

Merged

padreug merged 1 commit from chore/remove-stale-test-init into v2-bitspire

2026-05-31 17:29:30 +00:00

padreug commented

2026-05-31 17:25:31 +00:00

Owner

Closes #34.

Summary

Deletes tests/test_init.py. The lone test (test_router) was leftover scaffolding from the LNBits extension cookiecutter (commit 42b5eda, Aug 2024). It has been failing for the lifetime of the repo because:

The test is @pytest.mark.asyncio-decorated, but the project deliberately doesn't ship pytest-asyncio — our convention is asyncio.run inside the test body (documented in tests/test_cassette_state_consumer.py:20-23 header).
The body asserts nothing the extension-load boot path doesn't already cover. Any router-construction failure would surface at every dev container restart and at every other test that imports from the package.

Result

Test suite goes from 1 failed, 161 passed (on feat/roster-resolver) / 1 failed, 155 passed (on v2-bitspire baseline pre-resolver) to 155 passed, 0 failed.

Test plan

pytest /shared/extensions/satmachineadmin/tests/ inside the dev container → 155 passed
Extension still boots cleanly (verified earlier in the resolver-branch boot smoke — router-construction failure would surface there too)
Reviewer eyeballs git diff (single-file deletion, 11 lines)

Refs

Origin commit: 42b5eda (feat: code quality, upstream cookiecutter port — authored by dni ⚡)
Workaround pattern: tests/test_cassette_state_consumer.py:20-23
Discovered while verifying feat/roster-resolver (coord-log §17:25Z)

Closes #34. ## Summary Deletes `tests/test_init.py`. The lone test (`test_router`) was leftover scaffolding from the LNBits extension cookiecutter (commit `42b5eda`, Aug 2024). It has been failing for the lifetime of the repo because: 1. The test is `@pytest.mark.asyncio`-decorated, but the project deliberately doesn't ship `pytest-asyncio` — our convention is `asyncio.run` inside the test body (documented in `tests/test_cassette_state_consumer.py:20-23` header). 2. The body asserts nothing the extension-load boot path doesn't already cover. Any router-construction failure would surface at every dev container restart and at every other test that imports from the package. ## Result Test suite goes from **1 failed, 161 passed** (on `feat/roster-resolver`) / **1 failed, 155 passed** (on `v2-bitspire` baseline pre-resolver) to **155 passed, 0 failed**. ## Test plan - [x] `pytest /shared/extensions/satmachineadmin/tests/` inside the dev container → 155 passed - [x] Extension still boots cleanly (verified earlier in the resolver-branch boot smoke — router-construction failure would surface there too) - [ ] Reviewer eyeballs `git diff` (single-file deletion, 11 lines) ## Refs - Origin commit: `42b5eda` (`feat: code quality`, upstream cookiecutter port — authored by `dni ⚡`) - Workaround pattern: `tests/test_cassette_state_consumer.py:20-23` - Discovered while verifying `feat/roster-resolver` (coord-log §`17:25Z`)

padreug added 1 commit

2026-05-31 17:25:31 +00:00

chore(tests): remove stale test_init.py cookiecutter leftover

ci.yml / chore(tests): remove stale test_init.py cookiecutter leftover (pull_request) Failing after 0s

Details

7bab182abb

The lone test (`test_router`) has been failing for the lifetime of
the repo. It's `@pytest.mark.asyncio`-decorated but the project
deliberately doesn't ship `pytest-asyncio` (newer tests use
`asyncio.run` inside the body — see `test_cassette_state_consumer.py`
header), so the test is uncollectable in our runner. The body asserts
nothing the extension-load boot path doesn't already cover.

After this: full suite is 155/155 green. Closes #34.

padreug merged commit 7bab182abb into v2-bitspire

2026-05-31 17:29:30 +00:00

padreug deleted branch chore/remove-stale-test-init

2026-05-31 17:29:30 +00:00

padreug referenced this pull request

2026-05-31 18:05:56 +00:00

feat(v2): collision guard — refuse machines whose npub matches an operator account (closes #32) #33