fix(activities): toast on logged-out Create tap instead of opening dialog #64

Merged

padreug merged 2 commits from fix/activities-create-auth-toast into dev

2026-05-23 13:22:27 +00:00

padreug commented

2026-05-23 12:50:59 +00:00

Owner

Summary

The "Create" bottom-nav tab in the activities standalone was reachable when logged out: tapping it still opened the create-event dialog, even though the tab was visually ghosted.
Root cause: BottomNav.vue fires onTabClick regardless of tab.disabled — the disabled flag is opacity-only, not a click gate.
Fix: in activities-app/App.vue, the Create tab's onClick now checks isAuthenticated and shows a toast.info('Log in to create an activity', …) with a "Log in" action that routes to /login, mirroring BookmarkButton.vue / RSVPButton.vue. The disabled opacity stays as a visual cue.

Test plan

Log out of the activities standalone.
Tap the "+ Create" bottom-nav tab — verify the toast appears with a "Log in" action and the dialog does NOT open.
Tap "Log in" in the toast — verify navigation to /login.
Log back in, tap "+ Create" — verify the create-event dialog opens as before.
Confirm edit flow still works (open an existing event → Edit → dialog opens with the event populated).

🤖 Generated with Claude Code

## Summary - The "Create" bottom-nav tab in the activities standalone was reachable when logged out: tapping it still opened the create-event dialog, even though the tab was visually ghosted. - Root cause: `BottomNav.vue` fires `onTabClick` regardless of `tab.disabled` — the `disabled` flag is opacity-only, not a click gate. - Fix: in `activities-app/App.vue`, the Create tab's `onClick` now checks `isAuthenticated` and shows a `toast.info('Log in to create an activity', …)` with a "Log in" action that routes to `/login`, mirroring `BookmarkButton.vue` / `RSVPButton.vue`. The `disabled` opacity stays as a visual cue. ## Test plan - [x] Log out of the activities standalone. - [x] Tap the "+ Create" bottom-nav tab — verify the toast appears with a "Log in" action and the dialog does NOT open. - [x] Tap "Log in" in the toast — verify navigation to `/login`. - [x] Log back in, tap "+ Create" — verify the create-event dialog opens as before. - [x] Confirm edit flow still works (open an existing event → Edit → dialog opens with the event populated). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

padreug added 1 commit

2026-05-23 12:51:00 +00:00

fix(activities): toast on logged-out Create tap instead of opening dialog c5ba4a31be

BottomNav fires onClick regardless of tab.disabled — the opacity gate
was visual only. Mirror BookmarkButton/RSVPButton: show a toast.info
with a Log in action and bail before opening the create dialog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

padreug added the

app:activities

bug

labels

2026-05-23 12:51:17 +00:00

padreug added 1 commit

2026-05-23 13:21:58 +00:00

Merge branch 'dev' into fix/activities-create-auth-toast 297b05e8e5

padreug merged commit 297b05e8e5 into dev

2026-05-23 13:22:27 +00:00

padreug deleted branch fix/activities-create-auth-toast

2026-05-23 13:22:28 +00:00